Merged
Conversation
Member
mnajdova
commented
Oct 8, 2024
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-44038--material-ui.netlify.app/ Bundle size report |
Member
Author
mnajdova
commented
Oct 8, 2024
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Member
Does it work if you do ? |
Member
Author
|
The step was failing on the CI, check https://app.circleci.com/jobs/github/mui/material-ui/758364. |
Member
|
Does the lock file change when you execute that command? you can commit those changes |
Member
Author
Yeah it did, and I commited the changes, I was just surprised that there were changes, this is why I tagged you. |
DiegoAndai
approved these changes
Oct 8, 2024
|
|
||
| ### `@mui/material@6.1.3` | ||
|
|
||
| - ​<!-- 18 -->Change React.ReactElement<any> to React.ReactElement<unknown> (#43402) @sai6855 |
Member
There was a problem hiding this comment.
Those ​<!-- 18 --> feel like noise during the review and when reading the changelog source, I'm proposing we remove them: #44052.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.