[internal] Remove <-- from changelog#44052
Merged
mnajdova merged 1 commit intomui:masterfrom Oct 10, 2024
Merged
Conversation
oliviertassinari
added
the
internal
Netlify deploy previewhttps://deploy-preview-44052--material-ui.netlify.app/ Bundle size report |
This was referenced Oct 9, 2024
Merged
Janpot
approved these changes
Oct 9, 2024
mnajdova
approved these changes
Oct 9, 2024
Member
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Fair enough, the items are anyway sorted, so I don't think we are loosing much.
Member
Author
|
Alright, sweet. Oops, I didn't correctly rebase this PR. I missed some changes with this PR, fixed in 82a8253. |
oliviertassinari
added
the
scope: code-infra
Merged
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in #24614, I never understood the use case. In the latest releases https://github.com/mui/material-ui/issues?q=label%3Arelease+is%3Aclosed some maintainers remove them, some keep them, e.g. #44038 has it but the one before doesn't: #43957. So it feels like we should drop this, it adds so much noise during the release PR review.