[material-ui] Make the palette always return new light and dark object#44059
Merged
mnajdova merged 1 commit intomui:masterfrom Oct 10, 2024
Merged
[material-ui] Make the palette always return new light and dark object#44059mnajdova merged 1 commit intomui:masterfrom
mnajdova merged 1 commit intomui:masterfrom
Conversation
siriwatknp
added
the
type: enhancement
siriwatknp
added
customization: theme
Netlify deploy previewhttps://deploy-preview-44059--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
approved these changes
Oct 10, 2024
1 task
| expect(palette1.background.default).to.equal('#fff'); | ||
| expect(palette2.background.default).to.equal('#fff'); | ||
|
|
||
| palette1.background.default = '#000'; |
Member
There was a problem hiding this comment.
Interesting, we had the same bug since Material UI v1, I guess.
Comment on lines
-259
to
+267
| const modes = { dark, light }; | ||
| const modes = { dark: getDark(), light: getLight() }; |
Member
There was a problem hiding this comment.
We should refactor this then? It sounds wasteful to call getDark() or the other to then throw away the object: #44075.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue popup in #43708 when there are multiple calls from
createTheme.The root cause comes from the
palette.backgroundis not being recreated every time that thecreatePaletteis called,so if
palette.background.*is mutated, it affect all of the instances.The fix is to wrap the
lightanddarkobject in a function and call them inside thecreatePalette. Tests added.