Skip to content

[internal] Simplify createPalette#44075

Merged
oliviertassinari merged 3 commits intomui:masterfrom
oliviertassinari:clean-up-create-palette
Oct 12, 2024
Merged

[internal] Simplify createPalette#44075
oliviertassinari merged 3 commits intomui:masterfrom
oliviertassinari:clean-up-create-palette

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 11, 2024 •
edited
Loading

Seen in #44059 (comment). The goal is to reduce the memory pressure.

@oliviertassinari oliviertassinari added the internal Behind-the-scenes enhancement. Formerly called “core”. label Oct 11, 2024
@oliviertassinari oliviertassinari mentioned this pull request Oct 11, 2024
Merged
1 task
@mui-bot
Copy link

mui-bot commented Oct 12, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44075--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 6a0ad84

Janpot
Janpot approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Alternatively

const getDefault = { dark: getDark, light: getLight };

// ...

  ...getDefault[mode](),

could result in less code 🙂

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 12, 2024 •
edited
Loading

Yeah ok, hoisting this could be even simpler and have better performance.

Soon or later, we will need to get a lot more serious with performance monitoring. Maybe mui/mui-x#14804 (comment) is the solution.

@oliviertassinari oliviertassinari enabled auto-merge (squash) October 12, 2024 11:01
This was referenced Oct 12, 2024
Merged
Merged
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 12, 2024

Arf, it doesn't work, the test break, it changes the behavior.

Comparing https://tools-public.onrender.com/prod/pages/bundleSizes?circleCIBuildNumber=759455&baseRef=master&baseCommit=a25a365a4c66738f358ecd745bf3727c0ca9d5b6&prNumber=44075 and https://tools-public.onrender.com/prod/pages/bundleSizes?circleCIBuildNumber=759483&baseRef=master&baseCommit=a25a365a4c66738f358ecd745bf3727c0ca9d5b6&prNumber=44075, size seems to be the same.

Janpot
Janpot reviewed Oct 12, 2024
View reviewed changes
@oliviertassinari
Revert "even simpler"
6a0ad84 
This reverts commit 7859020
@oliviertassinari oliviertassinari merged commit a49333c into mui:master Oct 12, 2024
@oliviertassinari oliviertassinari deleted the clean-up-create-palette branch October 12, 2024 12:34
@oliviertassinari oliviertassinari mentioned this pull request Oct 12, 2024
Merged
@sai6855 sai6855 mentioned this pull request Oct 21, 2024
Closed
1 task
@Hoang-Nguyen-Huy Hoang-Nguyen-Huy mentioned this pull request Nov 9, 2024
Merged
@oliviertassinari oliviertassinari changed the title [core] Simplify createPalette [internal] Simplify createPalette Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oliviertassinari @mui-bot @Janpot