Skip to content

[docs] Link to docs on PRs#4349

Merged
oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari:add-danger
Dec 30, 2024
Merged

[docs] Link to docs on PRs#4349
oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari:add-danger

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 1, 2024

Working on #4348, I missed the easy helper comment (access to preview, links, etc.).

Same as mui/base-ui#394

@oliviertassinari oliviertassinari added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Nov 1, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Add Danger [docs] Link to docs on PRs Nov 1, 2024
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Nov 1, 2024
@mui-bot
Copy link

mui-bot commented Nov 1, 2024

Netlify deploy preview

https://deploy-preview-4349--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against c8210ab

Copy link
Collaborator

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to also be able to identify pages of the docs which have been modified and link to them from the auto-generated comment

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 5, 2024
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 30, 2024

Would be cool to also be able to identify pages of the docs which have been modified and link to them from the auto-generated comment

@bharatkashyap Issue created: mui/mui-public#260.

@oliviertassinari oliviertassinari merged commit a7f95d1 into mui:master Dec 30, 2024
@oliviertassinari oliviertassinari deleted the add-danger branch December 30, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants