Skip to content

[docs] Link to docs on PRs#394

Merged
oliviertassinari merged 5 commits intomui:masterfrom
oliviertassinari:report-link-to-doc
May 10, 2024
Merged

[docs] Link to docs on PRs#394
oliviertassinari merged 5 commits intomui:masterfrom
oliviertassinari:report-link-to-doc

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 4, 2024

Working on #393, I have noticed that we are missing the easy access link to the docs.

SCR-20240504-pmag

I faced a bit working on this danger/danger-js#1180. I removed the formatFileToLink() import; The logic feels broken anyway, at least, in my view. In the end, this PR is close to what MUI X's uses. I think it will be great to normalize the markdown output at one point. I don't think it's great right now, but it's a larger scope. I'm going with the bare minimum possible change, to still place us a step forward.

I think we will need to aggregate bundle size reports too in the future: #201.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. scope: docs-infra labels May 4, 2024
@mui-bot
Copy link

mui-bot commented May 4, 2024

Netlify deploy preview

https://deploy-preview-394--base-ui.netlify.app/

Generated by 🚫 dangerJS against 7fef0d1

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 7, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 8, 2024
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari added a commit to mui/pigment-css that referenced this pull request May 9, 2024
oliviertassinari added a commit to mui/material-ui that referenced this pull request May 9, 2024
@oliviertassinari oliviertassinari merged commit 1980ee7 into mui:master May 10, 2024
@oliviertassinari oliviertassinari deleted the report-link-to-doc branch May 10, 2024 10:46
@michaldudak michaldudak added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label May 22, 2025
prodigy1125 added a commit to prodigy1125/pigment-css that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants