Add direct-vuex store and move rendering logic into vue component#121
Merged
Add direct-vuex store and move rendering logic into vue component#121
Conversation
This was referenced Dec 7, 2020
waxlamp
approved these changes
Dec 8, 2020
Contributor
waxlamp
left a comment
There was a problem hiding this comment.
I've looked this change set over but I don't think there's any meaningful way I can provide an actual review. In lieu of that, I'm rubber stamping this with the understanding that if anything breaks we'll fix it in small, targeted PRs (as we usually do, excluding this one).
Thanks for all the effort on this, @JackWilb.
Member
Author
|
Sounds good. Thanks, Roni. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was fixed before, but we should definitely close #71 since we're using scaleLinear for the bars in the re-write
Closes #101
Closes #108
This is the first of a few steps to get the app to a state where it's easier to get up to speed with the app, and to add new features.
In this gargantuan change set you will find the following:
TODOs for (hopefully!) smaller follow ups:
File issue for re-implementing provenanceSee Add provenance tracking to select and de-select nodes #122 for new implementation of the provenance librarysimulationLinksshould be made from a deep copy of network so the original network is not mutated (this will make the download button work much better) (Simulation links should be set from a deep copy so that the links in network are untouched #130)Nodes can wander off the svgSee Force nodes to stay on the svg #123