Skip to content

Add direct-vuex store and move rendering logic into vue component#121

Merged
JackWilb merged 65 commits intomasterfrom
re-architect
Dec 9, 2020
Merged

Add direct-vuex store and move rendering logic into vue component#121
JackWilb merged 65 commits intomasterfrom
re-architect

Conversation

@JackWilb
Copy link
Copy Markdown
Member

@JackWilb JackWilb commented Nov 16, 2020

I think this was fixed before, but we should definitely close #71 since we're using scaleLinear for the bars in the re-write
Closes #101
Closes #108

This is the first of a few steps to get the app to a state where it's easier to get up to speed with the app, and to add new features.

In this gargantuan change set you will find the following:

  • The addition of a VueX store
  • Migration of logic from separate ts files into the components (no class to worry about with the nodelink)
  • The reduction of D3 logic where possible, in favor of using Vue for as much of the DOM rendering as possible
  • Removal of the provenance library (to be added back by tracking the VueX store in a follow up)
  • Migration of all components to TypeScript
  • All components now use Vue.extend() for better TypeScript typing
  • Integration of CSS into the components
  • All functionality is preserved

TODOs for (hopefully!) smaller follow ups:

@JackWilb JackWilb changed the title [WIP] Add direct-vuex store and move rendering logic into vue component Add direct-vuex store and move rendering logic into vue component Dec 3, 2020
@JackWilb JackWilb requested a review from waxlamp December 3, 2020 22:30
@JackWilb JackWilb marked this pull request as ready for review December 3, 2020 22:32
Copy link
Copy Markdown
Contributor

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked this change set over but I don't think there's any meaningful way I can provide an actual review. In lieu of that, I'm rubber stamping this with the understanding that if anything breaks we'll fix it in small, targeted PRs (as we usually do, excluding this one).

Thanks for all the effort on this, @JackWilb.

@JackWilb
Copy link
Copy Markdown
Member Author

JackWilb commented Dec 8, 2020

Sounds good. Thanks, Roni.

@JackWilb JackWilb mentioned this pull request Dec 8, 2020
@JackWilb JackWilb merged commit 27f218f into master Dec 9, 2020
@JackWilb JackWilb deleted the re-architect branch December 9, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more type safety through the app Marker size control doesn't have any effect anymore Use d3 scales for the bars

2 participants