Enable eslint rules that were disabled before refactor#124
Merged
Conversation
waxlamp
previously approved these changes
Dec 11, 2020
Contributor
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
Looks good! Approving despite leaving my suggestions, since I'll leave those to your discretion.
Member
Author
|
Thanks for the thorough review @waxlamp, I've addressed all your comments. Had to force push to use min, not max |
JackWilb
force-pushed
the
re-enable-rule
branch
from
84fc61c to
e541f28
Compare
waxlamp
approved these changes
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #121
Closes #117 when we address my line length question
The error thrown for #116 is no longer an issue after #121. This removes the no-mutating-props exception, thus closes #116
I've re-enabled
no-mutating-propsandno-param-reassignapp wide, and have disabled the rule on the specific lines that need it. I also modified theno-underscore-dangleto explicitly allow_id,_from, and_to, since those are the actual values we need from arango, as opposed to disabling the rule entirely.Also, we have no line length limit at the moment and it's not causing any issues. I think enforcing a line length limit just adds development overhead for refactoring long lines, without much added readability. I'd love to get your thoughts, though. Leaving no line length limits means that our configuration closely matches the same from the multinet-client.