Make a deep copy of the network for simulationLinks#134
Merged
Conversation
JackWilb
force-pushed
the
deep-copy-network
branch
from
e28bcd4 to
ec78699
Compare
Member
Author
|
Rebased onto master and resolved the conflict caused by change from #124 (comment). |
waxlamp
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
I decided to use a
JSON.parse(JSON.stringify())since the data that we get from MultiNet is made of properties that are all JSON serializable, and there's no easier option that doesn't require importing more libraries.This means that the simulation doesn't update the
sourceandtargetproperties on the links in the store with references to the nodes that are the source and target.