Conversation
waxlamp
approved these changes
Jan 13, 2022
Contributor
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
This does indeed fix the version to be 3.2.x. I think that's fine for now. We can be more deliberate about what Django version we're on at some point but right now that seems like the right choice.
Member
|
The reason that the tests for this are failing is due to an upstream change in
I think we can merge this PR, and I can open a separate PR to fix the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
No, I have noticed this issue when rebuilding the django container locally, though.
Give a longer description of what this PR addresses and why it's needed
This fixes the django major (and maybe minor version) to 3(.2). This stops the django containers, and presumably the heroku deployment, from using django v4.0, which our code is not compatible with. We're using some deprecated and removed functions.
We should hold off on merging any other PR until this is merged.
Provide pictures/videos of the behavior before and after these changes (optional)
N/A
Are there any additional TODOs before this PR is ready to go?
No