Conversation
|
Removed myself from the reviewer list--please go with Jake's recommendations. |
jjnesbitt
left a comment
There was a problem hiding this comment.
Looks like there's an import failure in a sub-dependency, I can look into fixing that (unless you know what to do @JackWilb). Otherwise, I think this PR looks good.
One thing I'm curious about, is 5000 the right size for DOCUMENT_CHUNK_SIZE? It's pretty arbitrary, although I think any number we set will be arbitrary.
82063fb to
a32aea4
Compare
CircleCI was trying to use django 4, so I just rebased onto main after #89. Now the tests are failing because of #91
Yeah, I'm not sure where the sweet spot is. Let's leave it at this for now and if we need to do some fine-tuning in the future, we can. |
Depends #89
Does this PR close any open issues?
Closes #85
Give a longer description of what this PR addresses and why it's needed
This chunks the upload using hints from #85. I used almost exactly the same syntax, while making sure to not use the
readonlyuser. The upload runs with chunks of 5000 rows, which may be too small.Provide pictures/videos of the behavior before and after these changes (optional)
N/A
Are there any additional TODOs before this PR is ready to go?
No.