Skip to content

Add an upload preview table with column type selectors#136

Merged
waxlamp merged 6 commits intomasterfrom
preview-table
Nov 20, 2020
Merged

Add an upload preview table with column type selectors#136
waxlamp merged 6 commits intomasterfrom
preview-table

Conversation

@waxlamp
Copy link
Copy Markdown
Contributor

@waxlamp waxlamp commented Nov 13, 2020

This uses @jtomeck's design for a preview table within a stepper to (1) select a CSV file to upload and (2) examine a sample of the data and set up column data types before (3) uploading the table to Multinet.

@jtomeck: I need help making my use of Vuetify have the right styles to match up to your design. For example:

  • the colors are wrong
  • the <v-select>s look ugly as sin
  • no finish flag in the stepper
  • the stepper got reduced to only two steps

Let me know what you think.

Closes #134

Copy link
Copy Markdown
Contributor

@jtomeck jtomeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a commit improving some of the look and styles. For some reason the table scrolling is not working properly. That went away when I removed the padding of the stepper content around the table. Do any of you see anything that could be wrong? If not I can remove the padding and it should resolve itself, I just like the look better without the padding. @waxlamp @AlmightyYakob

@waxlamp
Copy link
Copy Markdown
Contributor Author

waxlamp commented Nov 19, 2020

I just made a commit improving some of the look and styles. For some reason the table scrolling is not working properly. That went away when I removed the padding of the stepper content around the table. Do any of you see anything that could be wrong? If not I can remove the padding and it should resolve itself, I just like the look better without the padding. @waxlamp @AlmightyYakob

I think this looks great, @jtomeck.

I know there's a problem with scrolling--can we file an issue and fix that as it causes problems later?

@waxlamp waxlamp merged commit 2ab198c into master Nov 20, 2020
@waxlamp waxlamp deleted the preview-table branch November 20, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement preview table during CSV upload

2 participants