Add column type information to table creation call#138
Conversation
|
I think this looks really great! Just left a few suggestions |
|
Another suggestion I just thought of, which we'll likely want to do as a follow up: Since we've now got this type selection UI, we could add a We could remove this option from the first step, and just have it as another type in the column drop down in the second step. We would also likely default that to the There's important distinction from the rest of the types however, which is that there can only be one primary key column. We'd have to add some logic when it comes to selecting that type, and we'd need to create a new validation error on the server to handle multiple supplied primary keys, but those tasks seem fairly low-effort. Since this involves both server and client changes, we should probably address it in a separate issue, and move forward with this PR. However, I thought it was worthy of discussion. @waxlamp lmk what you think. |
Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com>
I think this is a good idea and I agree that we should address it in a followup. Can you an issue and link it back here? |
Changes: - `csvFileTypeRecommendations` -> `analyzeCSV` (function that now returns both a type recommendation *and* a table row sample) - `Recommendation` -> `CSVAnalysis` (type encompassing the new return value above) - `typeRecs` -> `analysis` (better name for the variable that gets the result of the analysis)
jjnesbitt
left a comment
There was a problem hiding this comment.
While I approve of these changes, I'm holding off my official approval until the proper version of multinetjs is listed.
5a86eb9 to
5a8cdb1
Compare

This PR makes use of multinet-app/multinetjs#22.
This uses the updated multinetjs library to send column type information at table upload time.
Depends on multinet-app/multinetjs#22 being merged and released.
Depends on #136.