In addition to Body, also sign Timestamp with the provided digest_method#1132
Closed
ospeek wants to merge 1 commit intomvantellingen:masterfrom
Closed
In addition to Body, also sign Timestamp with the provided digest_method#1132ospeek wants to merge 1 commit intomvantellingen:masterfrom
ospeek wants to merge 1 commit intomvantellingen:masterfrom
Conversation
Owner
|
Can you added a couple of unittests for this? |
Owner
|
Merged #1201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing a service with zeep, we found out that the optional Timestamp header was always signed using SHA1 instead of the supplied digest_method (SHA256 in our case). This fix will sign both the Body and the Timestamp using the provided digest_method.