Pass digest method when signing timestamp node#1201
Merged
mvantellingen merged 2 commits intomvantellingen:masterfrom Aug 15, 2021
Merged
Pass digest method when signing timestamp node#1201mvantellingen merged 2 commits intomvantellingen:masterfrom
mvantellingen merged 2 commits intomvantellingen:masterfrom
Conversation
Contributor
Author
|
Modified existing sign timestamp test to validate signature and digest methods have been passed |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a digest method other than the SHA1 default to be used when signing the timestamp node.
I see now that there is an existing similar PR (#1132 ) but I'll add a couple of tests to this one if that one is not moving.