feat(proposition): prepare for fetching dynamic proposition configuration #377

FreekVR · 2025-08-04T08:19:38Z

adds a new concept for a proposition config, to replace existing platform functionality in the future

related to INT-1084

needs #379

codecov · 2025-09-17T09:16:14Z

Codecov Report

❌ Patch coverage is 94.90566% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.41%. Comparing base (0cff271) to head (4bba719).

Files with missing lines	Patch %	Lines
src/Frontend/View/CarrierSettingsItemView.php	96.24%	5 Missing ⚠️
src/Frontend/Service/FrontendRenderService.php	0.00%	4 Missing ⚠️
...p/Options/Definition/CountryOfOriginDefinition.php	0.00%	2 Missing ⚠️
...c/App/Options/Definition/CustomsCodeDefinition.php	0.00%	2 Missing ⚠️
...ns/Definition/DisableDeliveryOptionsDefinition.php	0.00%	2 Missing ⚠️
...Options/Definition/FitInDigitalStampDefinition.php	0.00%	2 Missing ⚠️
.../App/Options/Definition/FitInMailboxDefinition.php	0.00%	2 Missing ⚠️
...c/App/Options/Definition/PackageTypeDefinition.php	0.00%	2 Missing ⚠️
src/Shipment/Model/CustomsDeclarationItem.php	75.00%	2 Missing ⚠️
...p/Order/Calculator/General/InsuranceCalculator.php	75.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@                 Coverage Diff                  @@
##             v3-proposition     #377      +/-   ##
====================================================
- Coverage             95.72%   95.41%   -0.32%     
- Complexity             1816     1942     +126     
====================================================
  Files                   343      346       +3     
  Lines                  6153     6517     +364     
====================================================
+ Hits                   5890     6218     +328     
- Misses                  263      299      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

This pull request implements a new proposition config system to replace existing platform functionality, introducing a shared proposition configuration approach as a proof of concept for INT-1084.

Key changes:

Adds proposition-based carrier configuration system
Updates test snapshots to reflect new carrier naming conventions (POSTNL instead of postnl)
Modifies various services to use proposition service instead of direct platform access

Reviewed Changes

Copilot reviewed 253 out of 569 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Multiple test snapshots	Updated to reflect new carrier naming conventions and data structures
tests/Unit files	Modified to use new proposition-based carrier features and testing infrastructure
src/Validation/Validator/CarrierSchema.php	Added proposition-based validation with backward compatibility
src/Settings files	Updated to support new proposition service while maintaining legacy compatibility
src/Shipment files	Modified to use proposition service for carrier and platform data

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 253 out of 573 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

NabDevs

Awesome job!

src/Proposition/Service/PropositionService.php

NabDevs

Awesome job!

src/Account/Service/AccountSettingsService.php

src/App/DeliveryOptions/Service/DeliveryOptionsService.php

src/App/Order/Calculator/General/InsuranceCalculator.php

src/Context/Model/DeliveryOptionsConfig.php

src/Frontend/Service/FrontendDataAdapter.php

src/Validation/Repository/SchemaRepository.php

tests/Unit/Account/Service/AccountSettingsServiceTest.php

tests/Unit/Frontend/Service/FrontendDataAdapterTest.php

src/Proposition/Service/PropositionService.php

FreekVR

.

src/Account/Service/AccountSettingsService.php

src/Proposition/Model/PropositionCarrierMetadata.php

src/Proposition/Service/PropositionService.php

FreekVR · 2025-10-02T11:01:26Z

src/Settings/Model/CarrierSettings.php

+    /**
+     * @deprecated use ALLOW_EXPRESS_DELIVERY instead
+     */
+    public const  ALLOW_DELIVERY_TYPE_EXPRESS             = 'allowExpressDelivery';


I mostly did this to be consistent, as all other options use the allow{Type}Delivery format, I can not otherwise generate these options in a loop in the frontend.

FreekVR · 2025-10-02T11:02:56Z

src/Shipment/Model/CustomsDeclarationItem.php

+     *
+     * @return string
+     */
+    private static function getLocalCountry(): string


Yes, I think that would be a good option. However, since it was already defined here, I opted not to do that refactor right now (mapToPlatformConfig will likely be replaced at some point)

src/Validation/Repository/SchemaRepository.php

tests/Unit/Base/AbstractPdkBootstrapperTest.php

… functions

…ing ShipmentOptions

process PR feedback and get propositions by ID rather than name to prevent having to map names to IDs and allow any new proposition to be supported by simply adding a new config file

… features

…arrier names

…tion (#377) replace PHP platform config with JSON proposition config files, and map it to existing definitions. This prepares the PDK for a future definition using a propositions API which determines available features and carriers. --------- Co-authored-by: Joeri van Veen <joeri@myparcel.nl> Co-authored-by: jochemgravendeel <jochem.gravendeel@myparcel.nl>

FreekVR force-pushed the feat/proposition-config branch 2 times, most recently from 58bd5b8 to 5a7f7e5 Compare August 5, 2025 14:26

FreekVR force-pushed the feat/proposition-config branch from b6157fc to 3cf3314 Compare August 15, 2025 09:51

FreekVR force-pushed the feat/proposition-config branch from b553fc3 to f5e4aaa Compare September 10, 2025 14:03

FreekVR force-pushed the feat/proposition-config branch from b940479 to 8cfe8b4 Compare September 23, 2025 14:56

FreekVR marked this pull request as ready for review September 24, 2025 14:22

FreekVR requested review from Copilot and removed request for Copilot September 24, 2025 14:22

FreekVR requested a review from a team as a code owner September 24, 2025 14:22

FreekVR requested a review from Copilot September 24, 2025 14:22

Copilot AI reviewed Sep 24, 2025

View reviewed changes

FreekVR changed the title ~~feat(proposition): proof of concept for implementing a shared proposition config~~ feat(proposition): prepare for fetching dynamic platform configuration Sep 24, 2025

FreekVR force-pushed the feat/proposition-config branch from ffb2990 to 3d348f1 Compare September 25, 2025 14:41

FreekVR requested a review from Copilot September 26, 2025 09:38

Copilot AI reviewed Sep 26, 2025

View reviewed changes

myparcel-bot bot force-pushed the feat/proposition-config branch 2 times, most recently from 639eaef to 8940626 Compare September 30, 2025 08:53

joerivanveen force-pushed the feat/proposition-config branch from 8940626 to f246c1f Compare September 30, 2025 09:23

FreekVR force-pushed the feat/proposition-config branch from f246c1f to 0280ca6 Compare September 30, 2025 13:12

NabDevs approved these changes Oct 1, 2025

View reviewed changes

src/Proposition/Service/PropositionService.php Show resolved Hide resolved

NabDevs approved these changes Oct 1, 2025

View reviewed changes

joerivanveen requested changes Oct 2, 2025

View reviewed changes

myparcel-bot bot added the changes requested (Auto) label Oct 2, 2025

FreekVR commented Oct 3, 2025

View reviewed changes

FreekVR force-pushed the feat/proposition-config branch from 435c33f to 4bba719 Compare October 3, 2025 08:35

FreekVR requested a review from joerivanveen October 3, 2025 08:35

FreekVR force-pushed the main branch from 0cff271 to 77c8ec4 Compare October 3, 2025 08:41

FreekVR changed the base branch from main to v3-proposition October 3, 2025 08:42

joerivanveen requested changes Oct 6, 2025

View reviewed changes

tests/Unit/Base/AbstractPdkBootstrapperTest.php Show resolved Hide resolved

FreekVR added 16 commits October 10, 2025 09:58

refactor: remove redundant definition

d18c4b9

refactor: improve coverage of caching functionality and remove unused…

5f5dfcb

… functions

test: more coverage

1227fd0

test: add coverage for FrontendDataAdapter and fix an issue with miss…

4085001

…ing ShipmentOptions

fix: do not merge sat/mon delivery into ShipmentOption attributes for BC

d82ed55

chore: remove dead code

2764d37

test: add coverage for json file processing

4684b80

chore: clean up insuranceCalculator

c0be0cb

chore: remove more dead code

312ba60

refactor!: remove all flespakket configs and snapshots

6f8fa0c

fix: use legacy platform name

9281c06

chore: clean up unused snapshots

9b5cffd

fix: legacy name is belgie not sendmyparcel

3a31f15

fix: restore belgie json schemas

58be222

refactor: get proposition by ID rather than name

57a6849

process PR feedback and get propositions by ID rather than name to prevent having to map names to IDs and allow any new proposition to be supported by simply adding a new config file

fix(proposition): fix error for carriers without any defined outbound…

2badbbd

… features

FreekVR force-pushed the feat/proposition-config branch from 0b07c5b to 2badbbd Compare October 10, 2025 07:59

FreekVR added 2 commits October 13, 2025 15:01

feat: handle proposition not found errors to allow API key re-entry

c9c3b80

fix: use legacy names for carrier calculator mapping

7f5a013

FreekVR force-pushed the feat/proposition-config branch from 69051cb to 7f5a013 Compare October 13, 2025 13:15

FreekVR added 4 commits October 14, 2025 17:25

fix: additional fixes for unknown proposition behaviour

9f50c55

fix: carrier returned by ExportOrderAction needs to be in legacy format

31fe125

style: add missing deprecation annotations

a1c28dc

fix: make carrier specific calculator work with both legacy and new c…

8cccf49

…arrier names

FreekVR merged commit f3652e9 into v3-proposition Oct 24, 2025
1 check passed

FreekVR deleted the feat/proposition-config branch October 24, 2025 12:53

feat(proposition): prepare for fetching dynamic proposition configuration #377

feat(proposition): prepare for fetching dynamic proposition configuration #377

Uh oh!

Conversation

FreekVR commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

NabDevs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NabDevs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FreekVR left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FreekVR Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

FreekVR Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

FreekVR commented Aug 4, 2025 •

edited

Loading

codecov bot commented Sep 17, 2025 •

edited

Loading

FreekVR left a comment •

edited

Loading