-
Notifications
You must be signed in to change notification settings - Fork 1
feat!: get some config values at runtime based on api key #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: get some config values at runtime based on api key #379
Conversation
96784fd to
8885701
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
============================================
+ Coverage 95.65% 95.72% +0.06%
+ Complexity 1833 1816 -17
============================================
Files 343 343
Lines 6172 6153 -19
============================================
- Hits 5904 5890 -14
+ Misses 268 263 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c2a01cb to
38c38a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements runtime configuration based on API keys by determining platform information from account settings rather than static configuration. This is a breaking change that modifies how platform determination works throughout the application.
- Removes static platform configuration and introduces dynamic platform determination based on account platform ID
- Refactors test infrastructure to use
TestBootstrapper::forPlatform()instead of deprecatedmockPlatform() - Updates snapshot tests to reflect changes in package type calculation behavior
Reviewed Changes
Copilot reviewed 37 out of 38 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/PlatformManager.php | Implements runtime platform determination using account settings |
| src/Base/PdkBootstrapper.php | Removes platform parameter and uses fixed namespace |
| tests/Bootstrap/TestBootstrapper.php | Adds new forPlatform() method for test setup |
| tests/factories/Account/Model/AccountFactory.php | Adds constructor parameter for platform ID initialization |
| src/Account/Platform.php | Swaps FLESPAKKET_ID and SENDMYPARCEL_ID constants |
| Multiple test files | Replaces mockPlatform() calls with TestBootstrapper::forPlatform() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
38c38a4 to
ffb1b90
Compare
ffb1b90 to
7c51b6d
Compare
..._international_mailbox_with_(belgie)__(BE)__(dhlforyou123,_dhlforyou)__(false,_false)__1.txt
Show resolved
Hide resolved
8c1aff8 to
ca84a97
Compare
ca84a97 to
e7ae1ef
Compare
* feat!: get some config values at runtime based on api key
* feat!: get some config values at runtime based on api key
* feat!: get some config values at runtime based on api key
* feat!: get some config values at runtime based on api key
INT-1049