Skip to content

Conversation

@joerivanveen
Copy link
Contributor

INT-1049

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.72%. Comparing base (ad6bee4) to head (e7ae1ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #379      +/-   ##
============================================
+ Coverage     95.65%   95.72%   +0.06%     
+ Complexity     1833     1816      -17     
============================================
  Files           343      343              
  Lines          6172     6153      -19     
============================================
- Hits           5904     5890      -14     
+ Misses          268      263       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joerivanveen joerivanveen force-pushed the feat/get-some-config-values-at-runtime-based-on-api-key branch 2 times, most recently from c2a01cb to 38c38a4 Compare August 12, 2025 14:59
@joerivanveen joerivanveen marked this pull request as ready for review August 14, 2025 14:44
Copilot AI review requested due to automatic review settings August 14, 2025 14:44
@joerivanveen joerivanveen requested a review from a team as a code owner August 14, 2025 14:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements runtime configuration based on API keys by determining platform information from account settings rather than static configuration. This is a breaking change that modifies how platform determination works throughout the application.

  • Removes static platform configuration and introduces dynamic platform determination based on account platform ID
  • Refactors test infrastructure to use TestBootstrapper::forPlatform() instead of deprecated mockPlatform()
  • Updates snapshot tests to reflect changes in package type calculation behavior

Reviewed Changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Platform/PlatformManager.php Implements runtime platform determination using account settings
src/Base/PdkBootstrapper.php Removes platform parameter and uses fixed namespace
tests/Bootstrap/TestBootstrapper.php Adds new forPlatform() method for test setup
tests/factories/Account/Model/AccountFactory.php Adds constructor parameter for platform ID initialization
src/Account/Platform.php Swaps FLESPAKKET_ID and SENDMYPARCEL_ID constants
Multiple test files Replaces mockPlatform() calls with TestBootstrapper::forPlatform()

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@myparcel-bot myparcel-bot bot force-pushed the feat/get-some-config-values-at-runtime-based-on-api-key branch from 38c38a4 to ffb1b90 Compare September 16, 2025 07:45
@joerivanveen joerivanveen force-pushed the feat/get-some-config-values-at-runtime-based-on-api-key branch from ffb1b90 to 7c51b6d Compare September 16, 2025 19:27
@myparcel-bot myparcel-bot bot added changes requested (Auto) and removed changes requested (Auto) labels Sep 23, 2025
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Sep 23, 2025
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Sep 23, 2025
@joerivanveen joerivanveen self-assigned this Sep 25, 2025
@myparcel-bot myparcel-bot bot force-pushed the feat/get-some-config-values-at-runtime-based-on-api-key branch from 8c1aff8 to ca84a97 Compare September 26, 2025 12:44
@myparcel-bot myparcel-bot bot force-pushed the feat/get-some-config-values-at-runtime-based-on-api-key branch from ca84a97 to e7ae1ef Compare September 30, 2025 08:53
@joerivanveen joerivanveen added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2025
@joerivanveen joerivanveen added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2025
@joerivanveen joerivanveen merged commit c679a83 into main Sep 30, 2025
8 checks passed
@joerivanveen joerivanveen deleted the feat/get-some-config-values-at-runtime-based-on-api-key branch September 30, 2025 09:16
FreekVR pushed a commit that referenced this pull request Oct 7, 2025
* feat!: get some config values at runtime based on api key
FreekVR pushed a commit that referenced this pull request Oct 10, 2025
* feat!: get some config values at runtime based on api key
FreekVR pushed a commit that referenced this pull request Oct 31, 2025
* feat!: get some config values at runtime based on api key
FreekVR pushed a commit that referenced this pull request Nov 11, 2025
* feat!: get some config values at runtime based on api key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved (Auto)

Development

Successfully merging this pull request may close these issues.

4 participants