Translations update from Hosted Weblate#375
Conversation
weblate
force-pushed
the
weblate-ytify-web
branch
from
b1c5017 to
800a8de
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request synchronizes the translation files for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✅ Files skipped from review due to trivial changes (14)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates translation files from Weblate. However, it introduces an empty string for the new queue_reload_notification key in multiple language files. This will likely result in blank notifications being shown to users, creating a poor user experience. I have added comments to each affected file, recommending that a translation be provided or the key be removed to allow for a fallback to the default language.
Note: Security Review has been skipped due to the limited scope of the PR.
| "nav_logout": "تسجيل الخروج", | ||
| "player_video_resolution": "الدقة" | ||
| "player_video_resolution": "الدقة", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "লগআউট", | ||
| "player_video_resolution": "রেজোলিউশন" | ||
| "player_video_resolution": "রেজোলিউশন", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "Cerrar sesión", | ||
| "player_video_resolution": "Resolución" | ||
| "player_video_resolution": "Resolución", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "लॉगआउट", | ||
| "player_video_resolution": "रेज़ोल्यूशन" | ||
| "player_video_resolution": "रेज़ोल्यूशन", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "Logout", | ||
| "player_video_resolution": "Resolusi" | ||
| "player_video_resolution": "Resolusi", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "Deconectare", | ||
| "player_video_resolution": "Rezoluție" | ||
| "player_video_resolution": "Rezoluție", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "Выйти", | ||
| "player_video_resolution": "Разрешение" | ||
| "player_video_resolution": "Разрешение", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "library_about_ytify": "ytify Hakkında", | ||
| "nav_logout": "Oturumu Kapat", | ||
| "player_video_resolution": "Çözünürlük", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "لاگ آؤٹ", | ||
| "player_video_resolution": "ریزولیوشن" | ||
| "player_video_resolution": "ریزولیوشن", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
| "nav_logout": "登出", | ||
| "player_video_resolution": "分辨率" | ||
| "player_video_resolution": "分辨率", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
The translation for queue_reload_notification is an empty string. This will likely result in an empty notification being displayed to the user, which is a poor user experience. Please provide a translation for this key or remove it to allow a fallback to the default language (presumably English).
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/locales/zh.json`:
- Around line 224-225: Replace the empty string value for the translation key
"queue_reload_notification" with the English fallback text from en.json so
translations[key] || key will return a readable message (the resolver in
src/lib/stores/app.ts uses translations[key] || key); update the key in zh.json
(and the same key in pl.json, pt.json, bn.json, ur.json, hi.json, tr.json) to
the en.json value until a proper translation is provided, and add a simple CI
validation that fails if required locale keys are empty or only whitespace.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6196a260-2ffb-4aaa-ba59-884962536b01
📒 Files selected for processing (14)
src/locales/ar.jsonsrc/locales/bn.jsonsrc/locales/es.jsonsrc/locales/hi.jsonsrc/locales/id.jsonsrc/locales/ja.jsonsrc/locales/pl.jsonsrc/locales/pt.jsonsrc/locales/ro.jsonsrc/locales/ru.jsonsrc/locales/sr.jsonsrc/locales/tr.jsonsrc/locales/ur.jsonsrc/locales/zh.json
| "player_video_resolution": "分辨率", | ||
| "queue_reload_notification": "" |
There was a problem hiding this comment.
Use a non-empty value for this new translation key.
src/lib/stores/app.ts:28-35 resolves translations with translations[key] || key, so the empty string at Line 225 will fall back to the literal queue_reload_notification instead of a readable message. Please copy the src/locales/en.json value here until a real translation is available. The same issue appears at Line 224 in src/locales/pl.json, src/locales/pt.json, src/locales/bn.json, src/locales/ur.json, src/locales/hi.json, and src/locales/tr.json. Worth adding a locale validation check in CI so empty required translations fail fast.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/locales/zh.json` around lines 224 - 225, Replace the empty string value
for the translation key "queue_reload_notification" with the English fallback
text from en.json so translations[key] || key will return a readable message
(the resolver in src/lib/stores/app.ts uses translations[key] || key); update
the key in zh.json (and the same key in pl.json, pt.json, bn.json, ur.json,
hi.json, tr.json) to the en.json value until a proper translation is provided,
and add a simple CI validation that fails if required locale keys are empty or
only whitespace.
Currently translated at 96.4% (216 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/id/
Currently translated at 97.3% (218 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/es/
Currently translated at 97.7% (219 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/zh_Hans/
Currently translated at 96.4% (216 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ja/
Currently translated at 97.7% (219 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ur/
Currently translated at 98.2% (220 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ar/
Currently translated at 100.0% (224 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/sr/
Currently translated at 95.0% (213 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ro/
Currently translated at 92.8% (208 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/bn/
Currently translated at 96.8% (217 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/pt/
Currently translated at 97.3% (218 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/pl/
Currently translated at 95.9% (215 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/hi/
Currently translated at 99.1% (222 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/tr/
Currently translated at 97.7% (219 of 224 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ru/
Currently translated at 100.0% (225 of 225 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/fr/
weblate
force-pushed
the
weblate-ytify-web
branch
from
511ea00 to
de669d8
Compare
4 participants
Translations update from Hosted Weblate for ytify/web.
Current translation status:
Summary by CodeRabbit