Skip to content

Conversation

@v1rtl
Copy link
Collaborator

@v1rtl v1rtl commented Jan 30, 2026

Summary

  • Updated ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 (RootRegistry) to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707 (LegacyENSRegistry)
  • The previous address was incorrectly pointing to the RootRegistry instead of the LegacyENSRegistry

Test plan

  • Verify devnet indexing works correctly with the updated address

🤖 Generated with Claude Code

The ENSv1Registry was incorrectly pointing to the RootRegistry address.
Updated to use the correct LegacyENSRegistry address from devnet.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 30, 2026 09:47
@v1rtl v1rtl requested a review from a team as a code owner January 30, 2026 09:47
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: cfde6ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Jan 30, 2026

@v1rtl is attempting to deploy a commit to the NameHash Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

A single contract address constant is updated in the ENS test environment datasource configuration, changing the ENSv1Registry address from one value to another with no structural modifications.

Changes

Cohort / File(s) Summary
ENS Registry Configuration
packages/datasources/src/ens-test-env.ts
Updated ENSv1Registry contract address for the ENSRoot datasource from 0x9a676e781a523b5d0c0e43731313a708cb607508 to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A hop, skip, and hex code change,
The registry moves to a new exchange,
From chains of old to addresses new,
The ENS root finds cleaner rue! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the summary and test plan but lacks the 'Why' section explaining the motivation, and the Pre-Review Checklist is incomplete with unchecked boxes. Add a 'Why' section explaining the motivation for the address change and complete the Pre-Review Checklist by checking or updating the blocking items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating an ENSv1Registry address in the ens-test-env devnet config, which matches the single file modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a configuration error in the ens-test-env devnet setup where the ENSv1Registry address was incorrectly pointing to the RootRegistry contract instead of the LegacyENSRegistry contract.

Changes:

  • Updated ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 (RootRegistry) to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707 (LegacyENSRegistry)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

This PR fixes a configuration bug in the ens-test-env devnet setup where the ENSv1Registry address was incorrectly pointing to the RootRegistry contract instead of the LegacyENSRegistry contract.

What Changed:

  • Updated ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 (RootRegistry) to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707 (LegacyENSRegistry)

Root Cause:
The incorrect address was introduced in PR #1566 during a refactor to separate ENSv2 datasources. The ENSv1Registry was mistakenly assigned the same address as the RootRegistry (visible at line 104 in ENSv2Root datasource).

Impact:
This bug would have caused devnet indexing to fail or return incorrect data when querying ENSv1 registry information, as it was pointing to the wrong contract. The fix ensures the ENS indexer queries the correct legacy ENS registry contract on the devnet.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple, well-documented address correction that fixes a bug introduced in PR feat: separate ensv2 datasources out more correctly #1566. The new address is consistent with the pattern used in other namespace configurations (sepolia-v2.ts), and the comment clearly indicates this is the LegacyENSRegistry. No logic changes or side effects.
  • No files require special attention

Important Files Changed

Filename Overview
packages/datasources/src/ens-test-env.ts Corrected ENSv1Registry address from RootRegistry (0x9a67...) to LegacyENSRegistry (0x5fc8...)

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Config as ens-test-env.ts
    participant ENSv1 as ENSv1Registry Contract
    participant ENSv2 as RootRegistry Contract
    participant Indexer as ENS Indexer

    Note over Dev,Indexer: Before Fix (Incorrect Configuration)
    Dev->>Config: Read ENSv1Registry address
    Config-->>Dev: 0x9a67... (RootRegistry address)
    Dev->>ENSv2: Query ENSv1 data
    Note over ENSv2: Wrong contract!
    ENSv2-->>Dev: Incorrect/missing data
    Dev->>Indexer: Devnet indexing fails

    Note over Dev,Indexer: After Fix (Correct Configuration)
    Dev->>Config: Read ENSv1Registry address
    Config-->>Dev: 0x5fc8... (LegacyENSRegistry address)
    Dev->>ENSv1: Query ENSv1 data
    Note over ENSv1: Correct contract!
    ENSv1-->>Dev: Correct ENSv1 data
    Dev->>Indexer: Devnet indexing succeeds
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@v1rtl v1rtl closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant