-
Notifications
You must be signed in to change notification settings - Fork 16
fix: update ENSv1Registry address in ens-test-env devnet config #1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The ENSv1Registry was incorrectly pointing to the RootRegistry address. Updated to use the correct LegacyENSRegistry address from devnet. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
@v1rtl is attempting to deploy a commit to the NameHash Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughA single contract address constant is updated in the ENS test environment datasource configuration, changing the ENSv1Registry address from one value to another with no structural modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a configuration error in the ens-test-env devnet setup where the ENSv1Registry address was incorrectly pointing to the RootRegistry contract instead of the LegacyENSRegistry contract.
Changes:
- Updated ENSv1Registry address from
0x9a676e781a523b5d0c0e43731313a708cb607508(RootRegistry) to0x5fc8d32690cc91d4c39d9d3abcbd16989f875707(LegacyENSRegistry)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile OverviewGreptile SummaryThis PR fixes a configuration bug in the What Changed:
Root Cause: Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Config as ens-test-env.ts
participant ENSv1 as ENSv1Registry Contract
participant ENSv2 as RootRegistry Contract
participant Indexer as ENS Indexer
Note over Dev,Indexer: Before Fix (Incorrect Configuration)
Dev->>Config: Read ENSv1Registry address
Config-->>Dev: 0x9a67... (RootRegistry address)
Dev->>ENSv2: Query ENSv1 data
Note over ENSv2: Wrong contract!
ENSv2-->>Dev: Incorrect/missing data
Dev->>Indexer: Devnet indexing fails
Note over Dev,Indexer: After Fix (Correct Configuration)
Dev->>Config: Read ENSv1Registry address
Config-->>Dev: 0x5fc8... (LegacyENSRegistry address)
Dev->>ENSv1: Query ENSv1 data
Note over ENSv1: Correct contract!
ENSv1-->>Dev: Correct ENSv1 data
Dev->>Indexer: Devnet indexing succeeds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Summary
0x9a676e781a523b5d0c0e43731313a708cb607508(RootRegistry) to0x5fc8d32690cc91d4c39d9d3abcbd16989f875707(LegacyENSRegistry)Test plan
🤖 Generated with Claude Code