-
Notifications
You must be signed in to change notification settings - Fork 16
fix: add correct ensv1 and ensv2 addresses to sepolia-v2 namespace #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughRefactored Sepolia v2 datasource to replace a namespace spread with explicit Changes
Sequence Diagram(s)(omitted — changes are configuration/ABI mappings without new multi-component runtime control flow) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
confirmed indexed to latest on sepolia with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes the sepolia-v2 namespace configuration to use correct ENS v1 and v2 contract addresses for the testing deployment. The configuration was previously inheriting addresses from the standard Sepolia deployment, which was incorrect for this separate testing namespace.
Changes:
- Removed inheritance from Sepolia namespace and added complete ENSRoot datasource configuration with dedicated ENSv1 contract addresses for the sepolia-v2 testing deployment
- Added ReverseResolverRoot datasource with all reverse resolver contract addresses
- Updated ENSv2Root and ENSv2ETHRegistry contract addresses and start blocks to match the testing deployment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile OverviewGreptile SummaryThis PR fixes a critical configuration bug where the sepolia-v2 namespace was incorrectly inheriting ENSv1 contract addresses from the standard sepolia deployment instead of using the dedicated temp testing deployment addresses. Key Changes:
Impact: Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Config as sepolia-v2.ts
participant ENSRoot as ENSRoot Datasource
participant ENSv2Root as ENSv2Root Datasource
participant ENSv2ETH as ENSv2ETHRegistry
participant ReverseResolver as ReverseResolverRoot
Note over Config: Before: Inherited from sepolia namespace
Note over Config: After: Complete standalone configuration
Config->>ENSRoot: Define ENSv1 contracts
Note over ENSRoot: Registry: 0x17795c119b8155ab9d3357c77747ba509695d7cb<br/>BaseRegistrar: 0xb16870800de7444f6b2ebd885465412a5e581614<br/>NameWrapper: 0xca7e6d0ddc5f373197bbe6fc2f09c2314399f028
Config->>ENSv2Root: Define ENSv2 Root contracts
Note over ENSv2Root: RootRegistry: 0x245de1984f9bb890c5db0b1fb839470c6a4c7e08<br/>ETHRegistry: 0x3f0920aa92c5f9bce54643c09955c5f241f1f763<br/>Updated startBlock: 9771261
Config->>ENSv2ETH: Define ENSv2 ETH Registry
Note over ENSv2ETH: ETHRegistry: 0xf332544e6234f1ca149907d0d4658afd5feb6831<br/>ETHRegistrar: 0x3334f0ebcbc4b5b7067f3aff25c6da8973690d54<br/>Updated addresses and blocks
Config->>ReverseResolver: Add reverse resolver contracts
Note over ReverseResolver: New datasource with 7 resolver contracts<br/>for different L2s and default resolution
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/datasources/src/sepolia-v2.ts`:
- Around line 32-89: The comment above the ENSRoot datasource incorrectly says
the placeholder UniversalRegistrarRenewalWithReferrer uses a startBlock of 0;
update that comment to reflect the actual implementation (startBlock: 9374708)
or explicitly note why the placeholder uses the Sepolia startBlock 9374708, so
the comment aligns with the UniversalRegistrarRenewalWithReferrer entry and the
startBlock property.
|
confirmed indexed to latest with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lightwalker-eth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shrugs Looks good, thanks 🫡
Summary
ENSRootdatasource config for sepolia-v2 (previously inherited from sepolia, which was incorrect)ReverseResolverRootdatasource with all reverse resolver addressesENSv2RootandENSv2ETHRegistrycontract addresses and start blocks to match the temp testing deploymentWhy
Testing
Notes for Reviewer (Optional)
UniversalRegistrarRenewalWithReferreruseszeroAddressas a placeholder since this contract doesn't exist in the sepolia-v2 deployment but is required by theregistrarsplugin and refactoring that is out-of-scopeChecklist