fix: update ENSv1Registry address in ens-test-env devnet config #1586

v1rtl · 2026-01-30T10:00:26Z

Summary

Updated ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 (RootRegistry) to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707 (LegacyENSRegistry)
The previous address was incorrectly pointing to the RootRegistry instead of the LegacyENSRegistry

Test plan

Verify devnet indexing works correctly with the updated address

🤖 Generated with Claude Code

The ENSv1Registry was incorrectly pointing to the RootRegistry address. Updated to use the correct LegacyENSRegistry address from devnet. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

changeset-bot · 2026-01-30T10:00:30Z

⚠️ No Changeset found

Latest commit: cfde6ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-30T10:00:48Z

📝 Walkthrough

Walkthrough

The ENSv1Registry contract address in the ENSRoot datasource test environment configuration is updated from one address value to another. This is a straightforward configuration value update with no structural or functional logic changes.

Changes

Cohort / File(s)	Summary
ENS Test Environment Configuration `packages/datasources/src/ens-test-env.ts`	Updated ENSv1Registry contract address in the ENSRoot datasource from `0x9a676e781a523b5d0c0e43731313a708cb607508` to `0x5fc8d32690cc91d4c39d9d3abcbd16989f875707`. No structural changes to the datasource definition.

Possibly related PRs

fix: add correct ensv1 and ensv2 addresses to sepolia-v2 namespace #1575: Also updates the ENSv1Registry address in the ENSRoot datasource (same contract entry modification across namespace files)
feat: separate ensv2 datasources out more correctly #1566: Reorganizes ENSRoot datasource definitions and moves registry entries, affecting the same datasource configuration area

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A registry address takes flight,
From old hex to new, shining bright,
Test environments fresh and true,
One little change, clean as dew! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete against the required template. The 'Why' section is missing, the 'Notes for Reviewer' section is absent, and the blocking pre-review checklist is not filled out.	Add the 'Why' section explaining the reason for the address change, complete the pre-review checklist by checking the blocking item, and optionally add notes for reviewers if needed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: updating the ENSv1Registry address in the ens-test-env devnet configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch update-devnet-addresses

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR fixes an incorrect contract address configuration in the ens-test-env devnet environment. The ENSv1Registry was mistakenly pointing to the ENSv2 RootRegistry address instead of its correct LegacyENSRegistry address.

Changes:

Updated ENSv1Registry address in ens-test-env configuration from the RootRegistry address to the correct LegacyENSRegistry address

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

greptile-apps · 2026-01-30T10:03:19Z

Greptile Overview

Greptile Summary

This PR corrects a configuration error in the ens-test-env devnet setup by updating the ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707.

Key Changes:

The ENSv1Registry address in the ENSRoot datasource now correctly points to the LegacyENSRegistry contract
Previously, it was incorrectly pointing to the RootRegistry address (which belongs to the ENSv2Root datasource)
The RootRegistry address (0x9a67...7508) remains correctly assigned in the ENSv2Root datasource configuration
This fix ensures proper separation between ENSv1 and ENSv2 contract configurations

Impact:

Affects devnet indexing behavior for the ens-test-env namespace
No other files or configurations are impacted by this change
Both addresses are properly formatted (lowercase, valid Ethereum addresses)

Confidence Score: 4/5

This PR is safe to merge with minimal risk - it's a straightforward address configuration fix
The change is limited to a single address update in a configuration file. The new address is properly formatted, and the fix correctly separates ENSv1 and ENSv2 contract configurations. However, the test plan checkbox is not completed, and manual verification of devnet indexing is needed to confirm the address is correct for the deployed contract.
No files require special attention beyond verifying the devnet indexing works correctly with the updated address

Important Files Changed

Filename	Overview
packages/datasources/src/ens-test-env.ts	Updated `ENSv1Registry` address from RootRegistry to LegacyENSRegistry - straightforward configuration fix

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Config as ens-test-env.ts
    participant ENSRoot as ENSRoot Datasource
    participant ENSv2 as ENSv2Root Datasource
    
    Note over Dev,ENSv2: Configuration Fix: ENSv1Registry Address Update
    
    Dev->>Config: Update ENSv1Registry address
    Note over Config: Old: 0x9a676e781a523b5d0c0e43731313a708cb607508<br/>(RootRegistry address)
    Note over Config: New: 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707<br/>(LegacyENSRegistry address)
    
    Config->>ENSRoot: ENSv1Registry points to correct contract
    Note over ENSRoot: ENSRoot datasource uses<br/>LegacyENSRegistry for ENSv1
    
    Config->>ENSv2: RootRegistry remains unchanged
    Note over ENSv2: ENSv2Root datasource uses<br/>RootRegistry at 0x9a67...7508
    
    Note over Dev,ENSv2: Result: ENSv1Registry and RootRegistry<br/>now point to their correct respective contracts

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

github-actions · 2026-01-30T10:12:27Z

🚀 Preview Packages - `update-devnet-addresses`

NPM Packages:

# Install latest preview for this branch
pnpm add @ensnode/datasources@preview-update-devnet-addresses
pnpm add @ensnode/ensnode-react@preview-update-devnet-addresses
pnpm add @ensnode/ensrainbow-sdk@preview-update-devnet-addresses
pnpm add @ensnode/ensnode-schema@preview-update-devnet-addresses
pnpm add @ensnode/ensnode-sdk@preview-update-devnet-addresses
pnpm add @ensnode/ponder-subgraph@preview-update-devnet-addresses
pnpm add @ensnode/ponder-metadata@preview-update-devnet-addresses
pnpm add @ensnode/ens-referrals@preview-update-devnet-addresses
pnpm add @ensnode/namehash-ui@preview-update-devnet-addresses

# Or install specific version
pnpm add @ensnode/ensnode-sdk@0.0.0-preview-update-devnet-addresses-20260130100603

Docker Images:

docker pull ghcr.io/namehash/ensnode/ensindexer:preview-update-devnet-addresses-cfde6bac
docker pull ghcr.io/namehash/ensnode/ensadmin:preview-update-devnet-addresses-cfde6bac
docker pull ghcr.io/namehash/ensnode/ensapi:preview-update-devnet-addresses-cfde6bac
docker pull ghcr.io/namehash/ensnode/ensrainbow:preview-update-devnet-addresses-cfde6bac

Build Info:

🎯 Target: 📦 NPM packages + 🐳 Docker images
📦 Version: 0.0.0-preview-update-devnet-addresses-20260130100603
📝 Commit: cfde6bac
🌿 Branch: update-devnet-addresses
⏰ Built: 2026-01-30 10:12:26 UTC
🔗 Workflow Run

🤖 This comment will be updated on subsequent publishing of release previews from the branch associated with this PR

Note: Preview packages are managed by changesets. NPM dist-tags can be cleaned up manually using npm dist-tag rm @ensnode/ensnode-sdk preview-update-devnet-addresses

fix: update ENSv1Registry address in ens-test-env devnet config

cfde6ba

The ENSv1Registry was incorrectly pointing to the RootRegistry address. Updated to use the correct LegacyENSRegistry address from devnet. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings January 30, 2026 10:00

v1rtl requested a review from a team as a code owner January 30, 2026 10:00

Copilot started reviewing on behalf of v1rtl January 30, 2026 10:00 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update ENSv1Registry address in ens-test-env devnet config #1586

fix: update ENSv1Registry address in ens-test-env devnet config #1586

Uh oh!

v1rtl commented Jan 30, 2026

Uh oh!

changeset-bot bot commented Jan 30, 2026

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

greptile-apps bot commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: update ENSv1Registry address in ens-test-env devnet config #1586

Are you sure you want to change the base?

fix: update ENSv1Registry address in ens-test-env devnet config #1586

Uh oh!

Conversation

v1rtl commented Jan 30, 2026

Summary

Test plan

Uh oh!

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 30, 2026

🚀 Preview Packages - update-devnet-addresses

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

🚀 Preview Packages - `update-devnet-addresses`