-
Notifications
You must be signed in to change notification settings - Fork 16
fix: update ENSv1Registry address in ens-test-env devnet config #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The ENSv1Registry was incorrectly pointing to the RootRegistry address. Updated to use the correct LegacyENSRegistry address from devnet. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe ENSv1Registry address in the ENS test environment configuration was updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the ENSv1Registry contract address in the ens-test-env devnet configuration. The address was incorrectly pointing to the RootRegistry contract and has been updated to point to the LegacyENSRegistry contract.
Changes:
- Updated ENSv1Registry address from
0x9a676e781a523b5d0c0e43731313a708cb607508to0x5fc8d32690cc91d4c39d9d3abcbd16989f875707in the ens-test-env datasource configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile OverviewGreptile SummaryFixed incorrect
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Config as ens-test-env.ts
participant ENSRoot as ENSRoot Datasource
participant ENSv1 as ENSv1Registry Contract
participant ENSv2 as ENSv2Root Datasource
participant RootReg as RootRegistry Contract
Note over Config: Before Fix
Dev->>Config: Configure ENSv1Registry address
Config->>ENSRoot: Set address: 0x9a67... (RootRegistry)
Note over ENSRoot,ENSv1: Incorrect! Points to RootRegistry
ENSRoot-->>ENSv1: ❌ Wrong contract reference
Note over Config: After Fix
Dev->>Config: Update ENSv1Registry address
Config->>ENSRoot: Set address: 0x5fc8... (LegacyENSRegistry)
Note over ENSRoot,ENSv1: Correct! Points to LegacyENSRegistry
ENSRoot-->>ENSv1: ✓ Correct contract reference
Note over ENSv2,RootReg: RootRegistry remains at<br/>0x9a67... in ENSv2Root datasource
Dev->>Config: Configure RootRegistry address
Config->>ENSv2: Set address: 0x9a67... (RootRegistry)
ENSv2-->>RootReg: ✓ Correct contract reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Summary
0x9a676e781a523b5d0c0e43731313a708cb607508(RootRegistry) to0x5fc8d32690cc91d4c39d9d3abcbd16989f875707(LegacyENSRegistry)Test plan
🤖 Generated with Claude Code