Skip to content

Conversation

@v1rtl
Copy link
Collaborator

@v1rtl v1rtl commented Jan 30, 2026

Summary

  • Updated ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 (RootRegistry) to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707 (LegacyENSRegistry)
  • The previous address was incorrectly pointing to the RootRegistry instead of the LegacyENSRegistry

Test plan

  • Verify devnet indexing works correctly with the updated address

🤖 Generated with Claude Code

The ENSv1Registry was incorrectly pointing to the RootRegistry address.
Updated to use the correct LegacyENSRegistry address from devnet.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 30, 2026 09:59
@v1rtl v1rtl requested a review from a team as a code owner January 30, 2026 09:59
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: cfde6ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The ENSv1Registry address in the ENS test environment configuration was updated from 0x9a676e781a523b5d0c0e43731313a708cb607508 to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707. The change maintains all other configuration entries unchanged.

Changes

Cohort / File(s) Summary
ENS Test Environment Configuration
packages/datasources/src/ens-test-env.ts
Updated ENSv1Registry contract address to reflect new deployment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A registry address doth change today,
Old chains give way to the new byteway,
With just one line, a hex so divine,
The test environment now does align! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the ENSv1Registry contract address in the ens-test-env devnet configuration. The address was incorrectly pointing to the RootRegistry contract and has been updated to point to the LegacyENSRegistry contract.

Changes:

  • Updated ENSv1Registry address from 0x9a676e781a523b5d0c0e43731313a708cb607508 to 0x5fc8d32690cc91d4c39d9d3abcbd16989f875707 in the ens-test-env datasource configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

Fixed incorrect ENSv1Registry address in the ens-test-env devnet configuration. The address was mistakenly pointing to the RootRegistry (0x9a676e781a523b5d0c0e43731313a708cb607508) instead of the LegacyENSRegistry (0x5fc8d32690cc91d4c39d9d3abcbd16989f875707).

  • The ENSv1Registry in the ENSRoot datasource now correctly references the LegacyENSRegistry contract
  • The RootRegistry address remains correctly configured in the ENSv2Root datasource at 0x9a67...
  • This aligns the devnet configuration with the proper contract deployments from the namechain devnet

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it corrects a configuration error
  • The change is a straightforward address correction fixing a clear misconfiguration. The ENSv1Registry was incorrectly pointing to the RootRegistry contract, and this PR updates it to point to the correct LegacyENSRegistry contract. The change is isolated to a single address in the configuration file, with no code logic changes.
  • No files require special attention

Important Files Changed

Filename Overview
packages/datasources/src/ens-test-env.ts Updated ENSv1Registry address from RootRegistry to LegacyENSRegistry address, fixing incorrect configuration

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Config as ens-test-env.ts
    participant ENSRoot as ENSRoot Datasource
    participant ENSv1 as ENSv1Registry Contract
    participant ENSv2 as ENSv2Root Datasource
    participant RootReg as RootRegistry Contract
    
    Note over Config: Before Fix
    Dev->>Config: Configure ENSv1Registry address
    Config->>ENSRoot: Set address: 0x9a67... (RootRegistry)
    Note over ENSRoot,ENSv1: Incorrect! Points to RootRegistry
    ENSRoot-->>ENSv1: ❌ Wrong contract reference
    
    Note over Config: After Fix
    Dev->>Config: Update ENSv1Registry address
    Config->>ENSRoot: Set address: 0x5fc8... (LegacyENSRegistry)
    Note over ENSRoot,ENSv1: Correct! Points to LegacyENSRegistry
    ENSRoot-->>ENSv1: ✓ Correct contract reference
    
    Note over ENSv2,RootReg: RootRegistry remains at<br/>0x9a67... in ENSv2Root datasource
    Dev->>Config: Configure RootRegistry address
    Config->>ENSv2: Set address: 0x9a67... (RootRegistry)
    ENSv2-->>RootReg: ✓ Correct contract reference
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant