feat: update depedencies and lock the versions #314

Keith-CY · 2019-05-09T17:54:30Z

No description provided.

ashchan · 2019-05-10T00:42:11Z

Restarted CI build.

ashchan

Please make sure CI pass.

duanyytop · 2019-05-10T01:59:49Z

Keys test case fail because of async

Keith-CY · 2019-05-10T02:33:23Z

CI passed

classicalliu · 2019-05-10T02:50:28Z

packages/neuron-wallet/src/services/transactions.ts

    for (const i of transaction.inputs!) {
      const input = new InputEntity()
-      input.outPointHash = i.previousOutput.hash
+      input.outPointTxHash = i.previousOutput.txHash


It's this version of SDK is still outPoint.txHash or outPoint.cell.txHash ?

It's this version of SDK is still outPoint.txHash or outPoint.cell.txHash ?

pre-release of v0.11, which uses outpoint of { txHash, index }

classicalliu · 2019-05-10T02:53:10Z

packages/neuron-wallet/package.json

  "husky": {
    "hooks": {
-      "pre-commit": "lint-staged"
+      "pre-commit": "lint-staged & yarn test"


& or &&? But I think test can remove from pre-commit, CI will check it.

&& is correct.

CI usually blocked

…e-commit

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency lerna to v7.4.2 (#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (#330) * refactor: introduce tslib --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency lerna to v7.4.2 (#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (#330) * chore(deps): update dependency @babel/core to v7.23.6 * chore(deps): update dependency eslint-plugin-import to v2.29.1 * refactor: introduce tslib * chore(deps): update dependency eslint to v8.56.0 * chore(deps): update react monorepo to v18 * chore(deps): update dependency wait-on to v7.2.0 * chore(deps): update dependency webpack to v5.89.0 * chore(deps): update dependency @types/styled-components to v5.1.34 * chore(deps): update node.js to v18.19.0 * refactor: update type declaration for react 18 * chore(deps): update peterjgrainger/action-create-branch action to v2.4.0 * chore(deps): update typescript-eslint monorepo to v5.62.0 * fix(deps): update dependency react-router-dom to v6.21.0 * fix(deps): update dependency sass to v1.69.5 * fix(deps): update dependency undici to v5.28.2 * chore(deps): update storybook monorepo to v7.6.6 (#342) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v4 (#349) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/github-script action to v7 (#350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v12.3.1 * chore(deps): update actions/setup-node action to v4 * chore(deps): update actions/stale action to v9 * chore(deps): update actions/upload-artifact action to v4 * chore(deps): update crazy-max/ghaction-import-gpg action to v6 (#355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: rollback wait-on because it hangs in tcp connection --------- Signed-off-by: Chen Yu <keithwhisper@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (nervosnetwork#330) * refactor: introduce tslib --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (nervosnetwork#330) * chore(deps): update dependency @babel/core to v7.23.6 * chore(deps): update dependency eslint-plugin-import to v2.29.1 * refactor: introduce tslib * chore(deps): update dependency eslint to v8.56.0 * chore(deps): update react monorepo to v18 * chore(deps): update dependency wait-on to v7.2.0 * chore(deps): update dependency webpack to v5.89.0 * chore(deps): update dependency @types/styled-components to v5.1.34 * chore(deps): update node.js to v18.19.0 * refactor: update type declaration for react 18 * chore(deps): update peterjgrainger/action-create-branch action to v2.4.0 * chore(deps): update typescript-eslint monorepo to v5.62.0 * fix(deps): update dependency react-router-dom to v6.21.0 * fix(deps): update dependency sass to v1.69.5 * fix(deps): update dependency undici to v5.28.2 * chore(deps): update storybook monorepo to v7.6.6 (nervosnetwork#342) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v4 (nervosnetwork#349) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/github-script action to v7 (nervosnetwork#350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v12.3.1 * chore(deps): update actions/setup-node action to v4 * chore(deps): update actions/stale action to v9 * chore(deps): update actions/upload-artifact action to v4 * chore(deps): update crazy-max/ghaction-import-gpg action to v6 (nervosnetwork#355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: rollback wait-on because it hangs in tcp connection --------- Signed-off-by: Chen Yu <keithwhisper@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

feat: update depedencies and lock the versions

0d2f4aa

Keith-CY requested review from ashchan, classicalliu and duanyytop May 9, 2019 17:54

ashchan approved these changes May 10, 2019

View reviewed changes

ashchan suggested changes May 10, 2019

View reviewed changes

duanyytop approved these changes May 10, 2019

View reviewed changes

classicalliu reviewed May 10, 2019

View reviewed changes

Keith-CY requested a review from ashchan May 10, 2019 02:51

classicalliu reviewed May 10, 2019

View reviewed changes

test(neuron-wallet): update tests for updated deps and add test in pr…

87a2d00

…e-commit

classicalliu approved these changes May 10, 2019

View reviewed changes

ashchan approved these changes May 10, 2019

View reviewed changes

ashchan merged commit 9af0f21 into nervosnetwork:develop May 10, 2019

Keith-CY pushed a commit that referenced this pull request Dec 10, 2023

chore(deps): update dependency lerna to v7.4.2 (#314)

e6c1c43

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: update depedencies and lock the versions #314

feat: update depedencies and lock the versions #314

Uh oh!

Keith-CY commented May 9, 2019

Uh oh!

ashchan commented May 10, 2019

Uh oh!

ashchan left a comment

Uh oh!

duanyytop commented May 10, 2019

Uh oh!

Keith-CY commented May 10, 2019

Uh oh!

classicalliu May 10, 2019

Uh oh!

Keith-CY May 10, 2019 •

edited

Loading

Uh oh!

classicalliu May 10, 2019

Uh oh!

classicalliu May 10, 2019

Uh oh!

Keith-CY May 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: update depedencies and lock the versions #314

feat: update depedencies and lock the versions #314

Uh oh!

Conversation

Keith-CY commented May 9, 2019

Uh oh!

ashchan commented May 10, 2019

Uh oh!

ashchan left a comment

Choose a reason for hiding this comment

Uh oh!

duanyytop commented May 10, 2019

Uh oh!

Keith-CY commented May 10, 2019

Uh oh!

classicalliu May 10, 2019

Choose a reason for hiding this comment

Uh oh!

Keith-CY May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

classicalliu May 10, 2019

Choose a reason for hiding this comment

Uh oh!

classicalliu May 10, 2019

Choose a reason for hiding this comment

Uh oh!

Keith-CY May 10, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Keith-CY May 10, 2019 •

edited

Loading