Skip to content

Enable send transaction #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashchan merged 2 commits into from
May 11, 2019
Merged

Enable send transaction #318

ashchan merged 2 commits into from
May 11, 2019

Conversation

@Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented May 11, 2019 •
edited
Loading

  1. remove the sendCapacity listener and use the wallet controller to handle the send capacity request.
  2. add id in send capacity request for identify requests.
  3. when the transaction fails, display an error message in Transfer View
  4. when the transaction succeeds, navigate to the Transaction View.
  5. add a type of {content: string, id: string} to error message in response to identify requests.
  6. update basic address verification in neuron-ui, it should have the length of 50
  7. use codeHash of 0x0000000000000000000000000000000000000000000000000000000000000001 in the wallet service to make lockhashes, it will be deprecated soon, should be updated.

NOTICE: the interfaces between wallet service and transaction service are incompatible now.

@Keith-CY Keith-CY requested a review from ashchan May 11, 2019 03:25
@ashchan ashchan merged commit 7cd8244 into nervosnetwork:develop May 11, 2019
@Keith-CY Keith-CY deleted the enable-send-transaction branch May 12, 2019 05:04
Keith-CY pushed a commit that referenced this pull request Dec 10, 2023
@renovate
fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (…
9d3d1b5 
…#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2023
@Keith-CY @renovate
Bump dependencies (#2980)
6640e21 
* chore(deps): update dependency lerna to v7.4.2 (#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (#330)

* refactor: introduce tslib

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 21, 2023
@Keith-CY @renovate
Bump dependencies (#2993)
e0e5578 
* chore(deps): update dependency lerna to v7.4.2 (#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (#330)

* chore(deps): update dependency @babel/core to v7.23.6

* chore(deps): update dependency eslint-plugin-import to v2.29.1

* refactor: introduce tslib

* chore(deps): update dependency eslint to v8.56.0

* chore(deps): update react monorepo to v18

* chore(deps): update dependency wait-on to v7.2.0

* chore(deps): update dependency webpack to v5.89.0

* chore(deps): update dependency @types/styled-components to v5.1.34

* chore(deps): update node.js to v18.19.0

* refactor: update type declaration for react 18

* chore(deps): update peterjgrainger/action-create-branch action to v2.4.0

* chore(deps): update typescript-eslint monorepo to v5.62.0

* fix(deps): update dependency react-router-dom to v6.21.0

* fix(deps): update dependency sass to v1.69.5

* fix(deps): update dependency undici to v5.28.2

* chore(deps): update storybook monorepo to v7.6.6 (#342)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (#349)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/github-script action to v7 (#350)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v12.3.1

* chore(deps): update actions/setup-node action to v4

* chore(deps): update actions/stale action to v9

* chore(deps): update actions/upload-artifact action to v4

* chore(deps): update crazy-max/ghaction-import-gpg action to v6 (#355)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: rollback wait-on because it hangs in tcp connection

---------

Signed-off-by: Chen Yu <keithwhisper@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Keith-CY @renovate @yanguoyu
Bump dependencies (nervosnetwork#2980)
c0b3c64 
* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (nervosnetwork#330)

* refactor: introduce tslib

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Keith-CY @renovate @yanguoyu
Bump dependencies (nervosnetwork#2993)
6535978 
* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (nervosnetwork#330)

* chore(deps): update dependency @babel/core to v7.23.6

* chore(deps): update dependency eslint-plugin-import to v2.29.1

* refactor: introduce tslib

* chore(deps): update dependency eslint to v8.56.0

* chore(deps): update react monorepo to v18

* chore(deps): update dependency wait-on to v7.2.0

* chore(deps): update dependency webpack to v5.89.0

* chore(deps): update dependency @types/styled-components to v5.1.34

* chore(deps): update node.js to v18.19.0

* refactor: update type declaration for react 18

* chore(deps): update peterjgrainger/action-create-branch action to v2.4.0

* chore(deps): update typescript-eslint monorepo to v5.62.0

* fix(deps): update dependency react-router-dom to v6.21.0

* fix(deps): update dependency sass to v1.69.5

* fix(deps): update dependency undici to v5.28.2

* chore(deps): update storybook monorepo to v7.6.6 (nervosnetwork#342)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (nervosnetwork#349)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/github-script action to v7 (nervosnetwork#350)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v12.3.1

* chore(deps): update actions/setup-node action to v4

* chore(deps): update actions/stale action to v9

* chore(deps): update actions/upload-artifact action to v4

* chore(deps): update crazy-max/ghaction-import-gpg action to v6 (nervosnetwork#355)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: rollback wait-on because it hangs in tcp connection

---------

Signed-off-by: Chen Yu <keithwhisper@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashchan ashchan ashchan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Keith-CY @ashchan