fix: pin colors to 1.4.0

[erezrokah]

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #3981

We don't use colors as a direct dependency, however by installing it as one, we can force package managers to use the unbroken version.

npm ls colors

├── colors@1.4.0
├─┬ node-version-alias@1.0.1
│ └─┬ all-node-versions@8.0.0
│   └─┬ fetch-node-website@5.0.3
│     └─┬ cli-progress@3.9.1
│       └── colors@1.4.0 deduped
├─┬ prettyjson@1.2.1
│ └── colors@1.4.0 deduped
└─┬ winston@3.3.3
  └─┬ logform@2.3.0
    └── colors@1.4.0 deduped

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)
🐒

[github-actions]

📊 Benchmark results

Comparing with 443cc60

Package size: 356 MB

⬆️ 0.00% increase vs. 443cc60

^  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  356 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (443cc60): 356 MB
• T-29 (686ad9a): 356 MB
• T-28 (d78c1cc): 356 MB
• T-27 (738ea86): 356 MB
• T-26 (ce10d6b): 356 MB
• T-25 (f5323c4): 356 MB
• T-24 (044d743): 356 MB
• T-23 (849362f): 356 MB
• T-22 (93a1662): 356 MB
• T-21 (ecfc91f): 356 MB
• T-20 (d6cb58f): 356 MB
• T-19 (b041045): 359 MB
• T-18 (f29e19e): 359 MB
• T-17 (0508317): 359 MB
• T-16 (4492ee7): 359 MB
• T-15 (c83c400): 359 MB
• T-14 (57701c2): 359 MB
• T-13 (21a55b9): 359 MB
• T-12 (cd8670b): 359 MB
• T-11 (cf9ea5a): 359 MB
• T-10 (1519207): 359 MB
• T-9 (bcd2e97): 359 MB
• T-8 (59f6af7): 359 MB
• T-7 (afdf556): 359 MB
• T-6 (495cf5d): 359 MB
• T-5 (c69ac03): 359 MB
• T-4 (c876483): 359 MB
• T-3 (c8962c1): 359 MB
• T-2 (382ed85): 359 MB
• T-1 (89dc8b5): 359 MB
• T (current commit): 356 MB

[lukasholzer]

LGTM!

[XhmikosR]

I don't think this PR fixes the issue... Since this project is using a lock file, this add a redundant dependency which does not enforce the package managers to respect it in any way.

One solution would be to use overrides and resolutions with whatever downsides they have.

The best solution would be to bug the direct parents of colors to pin the dependency on their side, until npm finally removes the offending packages.

[erezrokah]

This is a not ideal solution for yarn. With npm we didn't encounter the issue as we have a shrinkwrap file (which yarn doesn't support).
The idea is to rely on package managers de-deduping mechanism to install the correct version.

One solution would be to use overrides and resolutions with whatever downsides they have.

Those work at the consumer level, and not at the publisher level as far as I know (overrides is quite new as well and only supported in latest npm).

The best solution would be to bug the direct parents of colors to pin the dependency on their side, until npm finally removes the offending packages.

💯 And we'll follow up with that.

[XhmikosR]

The idea is to rely on package managers de-deduping mechanism to install the correct version.

But this change here does not do this. You can try it and you'll see that whatever you have in the root project as a dependency, is ignored downlevel.

[erezrokah]

Oh well, maybe because I didn't really pin it. Testing #3998

[XhmikosR]

@erezrokah I think you can update to the latest prettyjson which has colors now pinned too.