Skip to content

Comments

fix: pin colors to 1.4.0#3998

Closed
erezrokah wants to merge 1 commit intomainfrom
fix/pin_colors
Closed

fix: pin colors to 1.4.0#3998
erezrokah wants to merge 1 commit intomainfrom
fix/pin_colors

Conversation

@erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jan 10, 2022

Follow up to #3995, which actually pins colors

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 10, 2022
@erezrokah erezrokah requested a review from lukasholzer January 10, 2022 11:19
@erezrokah erezrokah marked this pull request as ready for review January 10, 2022 11:19
@github-actions
Copy link

📊 Benchmark results

Comparing with af27dc5

Package size: 356 MB

(no change)

^  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  356 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@erezrokah erezrokah mentioned this pull request Jan 10, 2022
5 tasks
@erezrokah
Copy link
Contributor Author

Closing as it doesn't work (tested with RC release https://github.com/netlify/cli/commits/releases/rc.0/8.6.17)

@erezrokah erezrokah closed this Jan 10, 2022
@lukasholzer
Copy link
Contributor

@erezrokah because yarn does not respect shrinkwrap json?

@erezrokah
Copy link
Contributor Author

erezrokah commented Jan 10, 2022

@erezrokah because yarn does not respect shrinkwrap json?

I was trying to rely on the de-duping mechanism to install the correct version, i.e. when yarn resolves which dependencies to install, it should install the version that matches all the relevant ranges. By pinning it, I thought I could "trick" yarn to install a specific version.
For some reason it doesn't work.

Looks like it's better to wait, see #3981 (comment)

@erezrokah erezrokah deleted the fix/pin_colors branch February 9, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug code to address defects in shipped code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants