Skip to content

Fix the web of Makefile cross-references across subdirs#1151

Merged
jimklimov merged 5 commits intonetworkupstools:masterfrom
jimklimov:fix-makefile-web
Oct 31, 2021
Merged

Fix the web of Makefile cross-references across subdirs#1151
jimklimov merged 5 commits intonetworkupstools:masterfrom
jimklimov:fix-makefile-web

Conversation

@jimklimov
Copy link
Copy Markdown
Member

@jimklimov jimklimov commented Oct 30, 2021

  • We had issues (links welcome) with builds of parts of codebase from sub-directories, rather than builds arranged normally from the root directory. Large part of the mess was the absence of dependencies on files (e.g. *.la archives) located in other sub-directories, so those were not automatically built when we wanted to e.g. configure && cd tests && make. Now such situations should resolve correctly.

@jimklimov jimklimov changed the title Fix the web of Makefiles and parallel builds Fix the web of Makefile cross-references across subdirs Oct 31, 2021
@jimklimov jimklimov merged commit 378169a into networkupstools:master Oct 31, 2021
@jimklimov jimklimov deleted the fix-makefile-web branch October 31, 2021 07:40
@jimklimov
Copy link
Copy Markdown
Member Author

Note for posterity: at least one build on a Debian 8 derived environment ended up creating directories literally named $(top_srcdir) and could not resolve some *.Plo files for the 4 sources impacted here, while compiling nut-scanner.

Commenting those 4 resulting include lines away from generated tools/nut-scanner/Makefile helped complete that build.

This was not seen anywhere else so I'd say it was either a strange system or some bug in older autotools.

But if this bites someone else, posted issues or better yet PRs are welcome. Returning to explicit ../ paths might be an option, but "really fixing" the issue for those and modern toolkits would be better.

jimklimov added a commit to jimklimov/nut that referenced this pull request Nov 4, 2021
jimklimov added a commit to jimklimov/nut that referenced this pull request Nov 5, 2021
This was referenced Nov 5, 2021
@jimklimov jimklimov requested review from aquette, clepple and zykh November 6, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant