Fix Makefile cleanup#1159
Merged
jimklimov merged 36 commits intonetworkupstools:masterfrom Nov 6, 2021
Merged
Conversation
…an-local target rules)
…rrent builddir, do avoid external ".deps/" usage
…tory into current builddir, do avoid external ".deps/" usage
…ind-recursion fails otherwise)
… (to overwrite older if any)
…g made, and no more (after any distcheck)
Member
Author
|
TODO/TRY: for later commits to make do with distchecks, instead of testing that linked source file is missing (dist seems to package it, and as a file not symlink), but better use NODIST keywords to not deliver the unneeded file at all. |
…PT if there is no configure script
…t-ing temporary symlinks as files
…to avoid dist-ing temporary symlinks as files
…"make distclean" but in "make realclean"
…eck" and factor into a method
…cript ecosystem (leave that to "realclean")
…s. "make realclean" (can be remade only by autogen.sh)
…ls, fall back to "maintainer-clean" support for wipingg the workspace
…, fall back to "maintainer-clean" support for wipingg the workspace
…istclean" to "maintainer-clean"
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Nov 6, 2021
This was referenced Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A git clone, build, check, possible
make distcheckand finallymake distcleanshould leave the Git workspace in pristine condition - no generated files remaining, no tracked files removed :)Note: in this case,
distcleanremoves just the files that can be recreated by running theconfigurescript, andrealcleanwipes also files created by running./autogen.shincluding the generatedconfigurescript and files that autotools copies from its own local installation. It was tested that both do not preclude the generated "dist tarball" to include such files, and be buildable withmake distcheck.The dist tarball contains same list of files as before (this took a bit of back and forth).
Due to peculiarities of some
makeimplementations, and our inter-directory dependencies much improved by #1151, this simple goal proved tricky to achieve; in particular alas$<is not always usable.