common/Makefile.am, tools/nut-scanner/Makefile.am: Introduce libcommonstr.la#2478
Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom Jun 24, 2024
Merged
Conversation
jimklimov
added
nut-scanner
refactor/fightwarn
34 tasks
This comment was marked as resolved.
This comment was marked as resolved.
…`libcommonstr.la` recipe A smaller helper library than `libcommonclient.la` which is sometimes an overkill, e.g. in `nut-scanner` where the `libupsclient.so/.dll` is loaded dynamically for "Old NUT" scans and there is no specific use for object files included into `libcommonclient.la`. More use-cases with DMF codebase (currently not yet upstreamed). Combined from a series of commits like * 3ba6b57 * c418728 * 5f16b7b * bc4cd95 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
force-pushed
the
issue-1316-libcommonstr
branch
from
4dd3856 to
c594c7a
Compare
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 17, 2024
…rkupstools#2463, networkupstools#2478] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rkupstools#2463, networkupstools#2478] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 18, 2024
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 18, 2024
…s#2478] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address part of #1316
A smaller helper library than
libcommonclient.lawhich is sometimes an overkill, e.g. innut-scannerwhere thelibupsclient.so/.dllis loaded dynamically for "Old NUT" scans and there is no specific use for object files included intolibcommonclient.la.More use-cases with DMF codebase (currently not yet upstreamed).
Combined from a series of commits like