Revise libwincompat.la vs. libcommonstr.la helpers in libnutscan build recipe#2491
Merged
jimklimov merged 7 commits intonetworkupstools:masterfrom Jun 25, 2024
Merged
Conversation
…al-nutscan.la to simplify nut-scanner recipes Initiated in DMF branch by commit 4fec99a Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…d of defining them at first assignment Would help later when merging DMF/FTY branches; for now just a bit of syntactic sugar and reduction of diffs against them. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ave libserial-nutscan.la Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…n_la_LDFLAGS Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ase after recent recipe changes Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…mmonstr.la Initially that embedding was done to help libnutscan builds with libcommonstr.la helper, but then a separate link with libnutwincompat.la was back-ported - so this line removal helps both to constrain the helper size/scope, and against a build-time conflict. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
Windows
nut-scanner
CI
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A piece of #1316 and follow-up to #2478