Problem: nutscan_init() called before debug is enabled#502
Merged
clepple merged 1 commit intonetworkupstools:masterfrom Nov 29, 2017
Merged
Problem: nutscan_init() called before debug is enabled#502clepple merged 1 commit intonetworkupstools:masterfrom
clepple merged 1 commit intonetworkupstools:masterfrom
Conversation
Solution: Move the call to this stateless function to the point after we parse arguments and just before we'd start the actual scans. Later this can be extended to also consider which scans were requested and so which libs to load. Thanks to @clepple for research in networkupstools#500 Signed-off-by: Jim Klimov <EvgenyKlimov@eaton.com>
clepple
approved these changes
Nov 27, 2017
Member
clepple
left a comment
clepple
left a comment
There was a problem hiding this comment.
Makes sense, but I don't have a good setup to test this fix.
Contributor
|
ahem... @jimklimov, what about the various places (when parsing opts or displaying help) that rely on a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Move the call to this stateless function to the point after we parse arguments and just before we'd start the actual scans. Later this can be extended to also consider which scans were requested and so which libs to load.
Thanks to @clepple for research in #500
Signed-off-by: Jim Klimov EvgenyKlimov@eaton.com