Skip to content

Respect ST_FLAG_IMMUTABLE in dstate_delinfo()#795

Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom
flobernd:master
Oct 7, 2020
Merged

Respect ST_FLAG_IMMUTABLE in dstate_delinfo()#795
jimklimov merged 2 commits intonetworkupstools:masterfrom
flobernd:master

Conversation

@flobernd
Copy link
Copy Markdown
Contributor

Fixes #737

@flobernd
Copy link
Copy Markdown
Contributor Author

@aquette @clepple Could you please have a look at this and the other apcupsd-ups related PRs (#796 and #797)?

@flobernd
Copy link
Copy Markdown
Contributor Author

Another 14 days passed - could you please take a look. Would help me a lot to have these changes in the upstream repository.

@flobernd
Copy link
Copy Markdown
Contributor Author

@aquette @clepple It has been over 3 months now and my PRs are still not merged. Can I assume this project is dead, or is there a different reason for not reviewing about 30 lines of code in such a long time?

For `state_delinfo()` not deleting immutable variables, comment this near the function and log for runtime hits to help troubleshooting.
@jimklimov jimklimov merged commit bd9300c into networkupstools:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dstate_delinfo() should respect ST_FLAG_IMMUTABLE (for override.*)

2 participants