Do not call dstate_delinfo() for LB-condition variables#796
Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom Oct 7, 2020
flobernd:bugfix/apcupsd-ignorelb
Merged
Do not call dstate_delinfo() for LB-condition variables#796jimklimov merged 1 commit intonetworkupstools:masterfrom flobernd:bugfix/apcupsd-ignorelb
dstate_delinfo() for LB-condition variables#796jimklimov merged 1 commit intonetworkupstools:masterfrom
flobernd:bugfix/apcupsd-ignorelb
Conversation
This commit fixes the `ignorelb` flag for the `apcupsd-ups` driver. Previusly "battery.charge" and "battery.runtime" was cleared before invoking `status_commit()` which caused the LB-condition to always be `false`.
jimklimov
approved these changes
Oct 7, 2020
Member
jimklimov
left a comment
jimklimov
left a comment
There was a problem hiding this comment.
Seems reasonable, hope it worked in HW testing :)
Contributor
Author
|
Thanks for merging. Yes, I tested extensively with my local APC device. Should be fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the
ignorelbflag for theapcupsd-upsdriver. Previusly "battery.charge" and "battery.runtime" was cleared before invokingstatus_commit()which caused the LB-condition to always befalse.