Fightwarn - the remainder of unreachable code warnings, and random small fixes#905
Merged
jimklimov merged 34 commits intonetworkupstools:masterfrom Nov 28, 2020
Merged
Conversation
…eturn types (avoid implicit cast in verification assert)
…egative returns (and errno where applicable)
…om temporary variable to return-value type
…fdef built blocks
jimklimov
force-pushed
the
fightwarn-unreachable-code
branch
from
58522aa to
debb1a2
Compare
…piler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…iler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…iler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…-limited int conversions
…parentheses like function pointers
jimklimov
force-pushed
the
fightwarn-unreachable-code
branch
from
debb1a2 to
9140376
Compare
Member
Author
|
At least partially tested for nut-scanner fixes (in the overall fightwarn effort branch applied) for discovery of nutclient, SNMP and NetXML devices - these worked. An USB driver for two ports was occupied and two port-busy reports appeared. (With offending drivers stopped, a re-run of nut-scanner discovered these devices). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up from #823 / #844 efforts to remove several classes of warnings from being seen in NUT build reports.