Fightwarn - the remainder of unreachable code warnings, and random small fixes#905

Merged

jimklimov merged 34 commits intonetworkupstools:masterfrom

jimklimov:fightwarn-unreachable-code

Nov 28, 2020

Commits on Nov 26, 2020

common/common.c: common/common.c: snprintfcat(): sort out the messy return types (avoid implicit cast in verification assert)
jimklimov
committed
common/common.c: common/common.c: snprintfcat(): replace asserts by negative returns (and errno where applicable)
jimklimov
committed
common/str.c: str_to_{u,}short{,_strict}() routines: explicit cast from temporary variable to return-value type
jimklimov
committed
common/upsconf.c: conf_args(): fix numargs type
jimklimov
committed
drivers/liebert-esp2.c: fix indentation
jimklimov
committed
common/strerror.c: do not warn about unreachable code in the web of ifdef built blocks
jimklimov
committed
drivers/bcmxcp.c: do not "break" just after "return"
jimklimov
committed
drivers/bestfcom.c: do not "break" just after "fatalx()"
jimklimov
committed
drivers/nutdrv_qx.c: wrap unreachable exit() added due to earlier compiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
jimklimov
committed
drivers/nutdrv_atcl_usb.c: copy-paste typo fix about unreachable code
jimklimov
committed
drivers/libusb.c: copy-paste typo fix about unreachable code
jimklimov
committed
drivers/libshut.c: satisfy pedantic macro parser (defined vs. used value)
jimklimov
committed
drivers/hidparser.c: satisfy pedantic macro parser (defined vs. used value)
jimklimov
committed
drivers/al175.c: align method docs with param names
jimklimov
committed
drivers/netxml-ups.c: align method docs with supported keywords
jimklimov
committed
drivers/netxml-ups.c: align method docs with param names
jimklimov
committed
tools/nut-scanner/scan_snmp.c: mark up NUT_UNUSED_VARIABLEs
jimklimov
committed
tools/nut-scanner/scan_xml_http.c: mark up NUT_UNUSED_VARIABLEs
jimklimov
committed
tools/nut-scanner/scan_ipmi.c: mark up NUT_UNUSED_VARIABLEs
jimklimov
committed
tools/nut-scanner/scan_avahi.c: mark up NUT_UNUSED_VARIABLEs
jimklimov
committed
clients/upsimage.c: annotate lots of routines with noreturn attr
jimklimov
committed
clients/upsimage.c: wrap unreachable exit() added due to earlier compiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
jimklimov
committed
clients/upsmon.c: annotate forceshutdown() with noreturn attr
jimklimov
committed
drivers/al175.c: annotate upsdrv_shutdown() with noreturn attr
jimklimov
committed
drivers/powercom.c: annotate shutdown*() with noreturn attr
jimklimov
committed
drivers/riello_usb.c: annotate shutdown*() with noreturn attr
jimklimov
committed
drivers/powercom.c: annotate upsdrv_shutdown() with noreturn attr
jimklimov
committed
drivers/powerman-pdu.c: annotate upsdrv_shutdown() with noreturn attr
jimklimov
committed
drivers/powercom.c: wrap unreachable exit() added due to earlier compiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
jimklimov
committed
drivers/netxml-ups.c: netxml_alarm_subscribe(): explicitly cast range-limited int conversions
jimklimov
committed
drivers/al175.c: declare function(void) prototypes explicitly
jimklimov
committed
tools/nut-scanner/scan_snmp.c: do not wrap variable definitions into parentheses like function pointers
jimklimov
committed

Commits on Nov 27, 2020

Merge branch 'master' into fightwarn-unreachable-code
jimklimov
authored

Commits on Nov 28, 2020

Merge branch 'master' into fightwarn-unreachable-code
jimklimov
authored