Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Mar 22, 2018

This adds tests to #135 & introduces integration and unit tests in general.

  • needs instrumented tests (tests running in emulator)
  • moved src, res to new folder structure (otherwise IT would not work) [for project test_client]
  • increased lint due to warning of outdated gradle deps

@tobiasKaminsky tobiasKaminsky changed the base branch from virusHandling to master March 22, 2018 09:36
@nextcloud nextcloud deleted a comment Mar 22, 2018
@nextcloud nextcloud deleted a comment Mar 22, 2018
@nextcloud nextcloud deleted a comment Mar 22, 2018
@tobiasKaminsky tobiasKaminsky mentioned this pull request Apr 4, 2018
3 tasks
@tobiasKaminsky tobiasKaminsky force-pushed the virusHandlingTestException branch from 5afdc37 to 3014b10 Compare April 4, 2018 11:20
@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@7332097). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #137   +/-   ##
=======================================
  Coverage          ?     0%           
=======================================
  Files             ?      2           
  Lines             ?    104           
  Branches          ?      7           
=======================================
  Hits              ?      0           
  Misses            ?    104           
  Partials          ?      0
Impacted Files Coverage Δ
.../owncloud/android/lib/testclient/TestActivity.java 0% <ø> (ø)
...estclient/SelfSignedConfidentSslSocketFactory.java 0% <ø> (ø)

@nextcloud nextcloud deleted a comment Apr 4, 2018
@nextcloud nextcloud deleted a comment Apr 4, 2018
@nextcloud nextcloud deleted a comment Apr 4, 2018
@nextcloud nextcloud deleted a comment Apr 4, 2018
@tobiasKaminsky tobiasKaminsky force-pushed the virusHandlingTestException branch from 3266bd6 to d1fb19d Compare April 4, 2018 12:06
@AndyScherzinger AndyScherzinger force-pushed the virusHandlingTestException branch from d1fb19d to e95584c Compare June 14, 2018 11:30
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment from tobiasKaminsky Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@AndyScherzinger AndyScherzinger force-pushed the virusHandlingTestException branch from 1875328 to e95584c Compare June 14, 2018 11:45
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@nextcloud nextcloud deleted a comment Jun 14, 2018
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 14, 2018

👍 fine by me

Approved with PullApprove

@tobiasKaminsky
Copy link
Member Author

Is there something missing here?
Although we do not (yet) have many integration tests, I would like to have this in, so that we can at least try to write some new 👍

@AndyScherzinger AndyScherzinger force-pushed the virusHandlingTestException branch from 5ed0797 to c632670 Compare July 20, 2018 13:42
@AndyScherzinger AndyScherzinger force-pushed the virusHandlingTestException branch from c632670 to 1d467df Compare August 29, 2018 07:06
tobiasKaminsky and others added 2 commits August 29, 2018 09:17
- add integration test for ExceptionParser
- include integration tests
@AndyScherzinger AndyScherzinger force-pushed the virusHandlingTestException branch from 1d467df to a6250e7 Compare August 29, 2018 07:17
@AndyScherzinger AndyScherzinger added this to the NC lib 1.1.0 milestone Aug 29, 2018
@AndyScherzinger AndyScherzinger merged commit 2141215 into master Aug 29, 2018
@AndyScherzinger AndyScherzinger deleted the virusHandlingTestException branch August 29, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants