Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Mar 15, 2018

Enhances existing xml parser to support exception and message.
Detects exception from anti-virus app.

Needed for: nextcloud/android#2353

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 15, 2018

👍 Nice :)

Approved with PullApprove

@tobiasKaminsky
Copy link
Member Author

@mario ping :-)

@mario
Copy link
Contributor

mario commented Mar 22, 2018

We need to change the name "Virus" to "Malware really".

@tobiasKaminsky tobiasKaminsky mentioned this pull request Mar 22, 2018
@tobiasKaminsky
Copy link
Member Author

Is it called Virus as the app is named virus and the exception is also naming it virus, so I thought it is better to stay in sync.
In general I like your idea, but I prefer to then change it also/first on server side.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@mario
Copy link
Contributor

mario commented Mar 22, 2018

@tobiasKaminsky link to the server app?

@mario
Copy link
Contributor

mario commented Mar 22, 2018

👍
Code wise fine, with the goal to change this to malware.

Approved with PullApprove

@tobiasKaminsky tobiasKaminsky merged commit 712ef8d into master Mar 22, 2018
@tobiasKaminsky tobiasKaminsky deleted the virusHandling branch March 22, 2018 13:36
@tobiasKaminsky tobiasKaminsky added this to the NC lib 1.0.40 milestone Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants