Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

  • in notification message, even with correct virus name
  • in upload list: generic virus warning

2018-03-15-110701 2018-03-15-112036

Do not try to resume virus upload automatically, as it is useless, but still the user can retry it manually

needs nextcloud/android-library#135
fixes #1391

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@AndyScherzinger
Copy link
Member

  • Can we add the notification message to the notification "BigText" field, since then the notification can be expanded showing the complete text?
  • Can we change the upload-error text to "Virus detected. Upload canceled" ?

@tobiasKaminsky
Copy link
Member Author

Can we add the notification message to the notification "BigText" field, since then the notification can be expanded showing the complete text?

I did not changed anything on Notification, but only added a more specific text. I currently also do not know what you mean with BigText, but this then should be a different PR as this affects complete uploading and maybe downloading?

Can we change the upload-error text to "Virus detected. Upload canceled" ?

I used the same text as on webUI for consistence.

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 15, 2018

👍 fine by me also regarding my questions

Approved with PullApprove

@AndyScherzinger
Copy link
Member

❗ This PR needs to fix the lib reference before it gets merged ❗
cc @tobiasKaminsky

@tobiasKaminsky
Copy link
Member Author

Thanks @AndyScherzinger, last time I forgot it, so the exclamation marks are indeed needed 🤣
-> rebased

@nextcloud nextcloud deleted a comment Mar 23, 2018
@AndyScherzinger
Copy link
Member

@mario ping for second review :)

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.2.0 milestone Apr 10, 2018
@mario
Copy link
Contributor

mario commented Apr 22, 2018

Rebase and 👍

- in notification message, even with correct virus name
- in upload list: generic virus warning

do not try to resume virus upload automatically, as it is useless, but still the user can retry it manually

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud nextcloud deleted a comment Apr 22, 2018
@AndyScherzinger AndyScherzinger merged commit 35bfc22 into master Apr 22, 2018
@AndyScherzinger AndyScherzinger deleted the virusHandling branch April 22, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper handle result when uploading a virus file

4 participants