-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Show correct error message if virus is detected #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I did not changed anything on Notification, but only added a more specific text. I currently also do not know what you mean with BigText, but this then should be a different PR as this affects complete uploading and maybe downloading?
I used the same text as on webUI for consistence. |
|
❗ This PR needs to fix the lib reference before it gets merged ❗ |
95694fc to
28cc44c
Compare
|
Thanks @AndyScherzinger, last time I forgot it, so the exclamation marks are indeed needed 🤣 |
|
@mario ping for second review :) |
|
Rebase and 👍 |
- in notification message, even with correct virus name - in upload list: generic virus warning do not try to resume virus upload automatically, as it is useless, but still the user can retry it manually Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
28cc44c to
18137d1
Compare
Do not try to resume virus upload automatically, as it is useless, but still the user can retry it manually
needs nextcloud/android-library#135
fixes #1391
Signed-off-by: tobiasKaminsky tobias@kaminsky.me