Plug custom logger implementation into Log_OC #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 21.52% 21.55% +0.03%
==========================================
Files 117 117
Lines 5152 5172 +20
Branches 700 700
==========================================
+ Hits 1109 1115 +6
- Misses 3915 3928 +13
- Partials 128 129 +1
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 21.52% 21.55% +0.03%
==========================================
Files 117 117
Lines 5152 5172 +20
Branches 700 700
==========================================
+ Hits 1109 1115 +6
- Misses 3915 3928 +13
- Partials 128 129 +1
|
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 21.52% 21.55% +0.03%
==========================================
Files 117 117
Lines 5152 5172 +20
Branches 700 700
==========================================
+ Hits 1109 1115 +6
- Misses 3915 3928 +13
- Partials 128 129 +1
|
This changes makes Log_OC implementation swappable at runtime, so app using this library can plug their own logger. Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii
force-pushed
the
plug-custom-impl-into-legacy-logger
branch
from
0d9c17f to
e29a7c3
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
This was referenced Jul 28, 2019
AndyScherzinger
approved these changes
Jul 29, 2019
tobiasKaminsky
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs nextcloud/android#4275
This changes makes Log_OC implementation swappable at runtime,
so app using this library can plug their own logger.
Signed-off-by: Chris Narkiewicz hello@ezaquarii.com