New logger implementation

[ezaquarii]

Fixes #4228

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[codecov]

Codecov Report

Merging #4275 into master will increase coverage by 0.34%.
The diff coverage is 61.63%.

@@             Coverage Diff             @@
##             master   #4275      +/-   ##
===========================================
+ Coverage     16.26%   16.6%   +0.34%     
  Complexity        1       1              
===========================================
  Files           340     351      +11     
  Lines         31184   31397     +213     
  Branches       4429    4446      +17     
===========================================
+ Hits           5071    5215     +144     
- Misses        25234   25306      +72     
+ Partials        879     876       -3

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
...in/java/com/nextcloud/client/di/ViewModelModule.kt	0% <ø> (ø)	0 <0> (ø)	⬇️
.../com/nextcloud/client/logger/ui/LogsEmailSender.kt	0% <0%> (ø)	0 <0> (?)
...com/owncloud/android/ui/activity/LogsActivity.java	0% <0%> (ø)	0 <0> (?)
...owncloud/android/ui/activity/SettingsActivity.java	38.44% <0%> (ø)	0 <0> (ø)	⬇️
...va/com/nextcloud/client/logger/ui/LogsViewModel.kt	0% <0%> (ø)	0 <0> (?)
...java/com/nextcloud/client/logger/ui/LogsAdapter.kt	0% <0%> (ø)	0 <0> (?)
.../main/java/com/nextcloud/client/logger/LogEntry.kt	100% <100%> (ø)	0 <0> (?)
src/main/java/com/owncloud/android/MainApp.java	55.11% <100%> (-0.52%)	0 <0> (ø)
src/main/java/com/nextcloud/client/logger/Level.kt	100% <100%> (ø)	0 <0> (?)
... and 31 more

[tobiasKaminsky]

This is GPL3+, an AppModule for example you used AGPL3+.
While the changes are minor, we encourage APGL3+.
(sorry if I mixed this up and falsly suggested GPL3+…)

[ezaquarii]

I think I copied the header from other source file - some are GPL3.

It should be all converted to AGPL3 now.

[ezaquarii]

Now it should be really done. (-:

[nextcloud-android-bot]

Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10299

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10300

[tobiasKaminsky]

https://www.kaminsky.me/nc-dev/android-integrationTests/10299/classes/com.nextcloud.client.logger.TestLogger.html

I tried to run these unit tests locally, but I always get:

java.lang.RuntimeException: Method d in android.util.Log not mocked. See http://g.co/androidstudio/not-mocked for details.

	at android.util.Log.d(Log.java)
	at com.nextcloud.client.logger.LoggerImpl.d(LoggerImpl.kt:66)
	at com.nextcloud.client.logger.TestLogger.queue overflow warning is logged(TestLogger.kt:231)

Am I missing something?

[ezaquarii]

@tobiasKaminsky
The only thing coming to my mind is

        testOptions {
            unitTests.returnDefaultValues = true
        }

in gradle. The above is required to enable bare-minimum system API mocks. If you restored the library dependency by restoring entire build.gradle by accident, this is what will happen.

[ezaquarii]

@tobiasKaminsky Testing platform code is tricky. I'm on the fence between having tests on android devices (androidTests) vs grabbing Robolectric. I decided to keep any extra dependencies out as long as we really don't require them.

[tobiasKaminsky]

If you restored the library dependency by restoring entire build.gradle by accident, this is what will happen.

I did not (yet) changed anything, but only checked it out.
I restart drone and give it also a new clean test locally.

I decided to keep any extra dependencies out as long as we really don't require them.

Good :-) If we come to the point where we have to change this, we should really be sure about the change.

[tobiasKaminsky]

Interesting. Running TestLogger via Android Studio results in error above.

But running "./gradlew testGplayDebugUnitTest" says that everything works:

com.nextcloud.client.logger.TestLogger > queue overflow warning is logged PASSED

--> so false alarm, but still strange

[tobiasKaminsky]

After CI, I will merge lib, and do all the needed stuff to get this in.

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10311.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

278

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	111
Security Warnings	46
Dodgy code Warnings	135
Total	410

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	112
Security Warnings	46
Dodgy code Warnings	136
Total	412