Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Aug 5, 2019

This is a change to use a headless emulator.

TODO

  • rebase, squash
  • remove dummy change

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Aug 5, 2019

@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@tobiasKaminsky tobiasKaminsky changed the title use different approach to open context menu Use emulator-headless Aug 6, 2019
@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@nextcloud nextcloud deleted a comment from codecov bot Aug 6, 2019
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #4296 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #4296      +/-   ##
===========================================
+ Coverage      16.1%   16.2%   +0.09%     
  Complexity        1       1              
===========================================
  Files           340     340              
  Lines         31184   31184              
  Branches       4429    4429              
===========================================
+ Hits           5022    5053      +31     
+ Misses        25295   25258      -37     
- Partials        867     873       +6
Impacted Files Coverage Δ Complexity Δ
...cloud/android/ui/activity/FileDisplayActivity.java 20.68% <0%> (+0.16%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 36.39% <0%> (+0.18%) 0% <0%> (ø) ⬇️
src/main/java/com/owncloud/android/MainApp.java 55.62% <0%> (+0.66%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 24.25% <0%> (+1.27%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+2.38%) 0% <0%> (ø) ⬇️
...ncloud/android/datamodel/SyncedFolderProvider.java 15.51% <0%> (+4.31%) 0% <0%> (ø) ⬇️
...com/owncloud/android/jobs/NContentObserverJob.java 53.33% <0%> (+53.33%) 0% <0%> (ø) ⬇️

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10297.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

278

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings112
Security Warnings46
Dodgy code Warnings136
Total412

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings112
Security Warnings46
Dodgy code Warnings136
Total412

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

We have 5 working CI in a row, I think this is great :-)

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 👍

@AndyScherzinger AndyScherzinger merged commit d79f8ee into master Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the enhanceScreenshotIT branch August 7, 2019 12:11
tobiasKaminsky added a commit that referenced this pull request Aug 8, 2019
3eecc09 New logger implementation (#4275)
d79f8ee use headless emulator (#4296)
7050933 revert library to master
612c2bd Bump json from 20180813 to 20190722 (#4298)
7ef012a [tx-robot] updated from transifex
7f87ba2 Bump json from 20180813 to 20190722
9ff067f Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
eaa24f1 Merge commit '79e8d59aa185d4c2fe728f4920df8e3511803d6d'
79e8d59 New logger implementation
329abff [tx-robot] updated from transifex
41c9ff1 daily dev 20190806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants