Add confirmation dialog on account deletion #116
Conversation
|
👍 |
|
Will have to change the latest commit. I can add whatever icon we want to use. Using android is bad because then the app loads the OS icons which depends on the OS version and we wouldn't want ICS icons for example. What is the icon you where aiming for @przybylski? |
|
recycle bin |
|
DONE :) d9716c0 |
|
Work fine on my phone. Can you also review @tobiasKaminsky? |
|
@AndyScherzinger please use autocompletion as you type my last name very often wrong and thus I do not get a notification ;-) |
|
Ups,sorry. The typos are from my phone, so no auto complete :( |
|
@tobiasKaminsky can you 👍 if this is fine with you, so the merge will be allowed by the plugin? :) |
res/values/strings.xml
Outdated
| <string name="about_title">About</string> | ||
| <string name="change_password">Change password</string> | ||
| <string name="delete_account">Remove account</string> | ||
| <string name="delete_account_warning">Delete account %s? Deleting cannot be undone.</string> |
There was a problem hiding this comment.
Very minor thing: I would do a linebreak for the second sentence.
|
LGTM |
AndyScherzinger
force-pushed
the
confirmAccountDeletion
branch
2 times, most recently
from
a06f769 to
9e46185
Compare
AndyScherzinger
force-pushed
the
confirmAccountDeletion
branch
from
9e46185 to
fca1e0d
Compare
3 participants
#109
also i did a small adjustment on UI since delete and password update button gave no visual feedback on press.