Display remote folder size #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Code LGTM |
| * Sorts list by Size | ||
| */ | ||
| public static Vector<OCFile> sortBySize(Vector<OCFile> files){ | ||
| final Integer val; |
Member
There was a problem hiding this comment.
final int multiplier = mSortAscending ? 1 : -1;
Member
|
👍 |
Member
Author
|
Fixed @przybylski code review comments 👍 |
Member
|
👍 |
Member
Author
|
@tobiasKaminsky please check and merge at will ;) Originally it is your PR, so it is yours to push the button :) |
Member
|
LGTM |
Member
|
Is this working for you? For me, I do not see any remote folder size :/ |
Member
Author
|
Erm...just checked and I don't see any either :( |
Member
Author
|
@tobiasKaminsky I fixed this here: #235 - please review and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folder size is now shown by remote computed folder size.
originally opened by @tobiasKaminsky on oC repo, rebased to latest master now.
According to the original discussion in the PR 1655 this will not work for Servers with oC version below 8 so it will always work for Nextcloud version > 9.x. So we are imho save here.
Please review @przybylski @tobiasKaminsky (I will do one too).
Since this is a minot change we might add this to the 1.2.0 release. Comments? :)