Restore display of remote folder size#235
Merged
tobiasKaminsky merged 2 commits intomasterfrom Sep 3, 2016
Merged
Conversation
Member
Author
|
@tobiasKaminsky can you do the code review? |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see comment on #123 - #123 (comment)
At some point the display seems to have been lost after the release of it (1.2.0).
So this PR restores it (ad67392#diff-af208ce61778201d6e0fadf55ea46469L199) and also adds the display of "Pending" like the web app for remote folder sizes not yet known (federated shares calculate this but not instantly) (https://github.com/nextcloud/android/pull/235/files#diff-36e882c1d5231f769f0209395ecf63c4R104). The display of "Pending" corresponds with the server part of handling this size display situations for federated shares (web view).