Add support for file versions

[tobiasKaminsky]

Resolves #1200

• adds support for versions
• only visible for NC14 user
• they are shown in activity stream
  • you can click on "revert" icon
• currently this is not MVP, but I will open up a new PR after the other file detail PRs by @AndyScherzinger are merged

TODO

• going back from detail view, reload of file list needs to be done, @AndyScherzinger do you have an idea for this?
• after successful restore: current downloaded file needs to be removed
• @rullzer what about old thumbnails? E.g. you have an image you change?

[codecov]

Codecov Report

Merging #2685 into master will decrease coverage by 0.02%.
The diff coverage is 3.37%.

@@            Coverage Diff            @@
##           master   #2685      +/-   ##
=========================================
- Coverage    6.52%   6.49%   -0.03%     
=========================================
  Files         285     287       +2     
  Lines       28896   29039     +143     
  Branches     4214    4231      +17     
=========================================
+ Hits         1886    1887       +1     
- Misses      26726   26868     +142     
  Partials      284     284

Impacted Files	Coverage Δ
...d/android/ui/dialog/RemoveFilesDialogFragment.java	0% <0%> (ø)	⬆️
...cloud/android/ui/helpers/FileOperationsHelper.java	0% <0%> (ø)	⬆️
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	⬆️
...ndroid/operations/RestoreFileVersionOperation.java	0% <0%> (ø)
...ud/android/ui/dialog/RemoveFileDialogFragment.java	0% <0%> (ø)	⬆️
.../java/com/owncloud/android/utils/DisplayUtils.java	5.83% <0%> (-0.05%)	⬇️
...roid/ui/fragment/FileDetailActivitiesFragment.java	0% <0%> (ø)	⬆️
...m/owncloud/android/services/OperationsService.java	0% <0%> (ø)	⬆️
...cloud/android/ui/adapter/FileDetailTabAdapter.java	0% <0%> (ø)	⬆️
...ncloud/android/ui/adapter/ActivityListAdapter.java	0% <0%> (ø)	⬆️
... and 5 more

[AndyScherzinger]

going back from detail view, reload of file list needs to be done, @AndyScherzinger do you have an idea for this?

There is no going back ;) On a tablet it would be a split pane between file list and file details :) I also did this for the file details already by introducing a listener interface (implemented by the activity) so you could just extend that one and ping the activity that it needs to refresh the other fragment/list :)

[rullzer]

@tobiasKaminsky how do you currently evaluate if the preview is still valid? Because you could use the same logic here. Either check the etag of the preview against the endpoint. Or check the etag of the actual file that should also change.

[tobiasKaminsky]

Thanks @rullzer, currently we are checking during sync if the modification date has changed and if so, we simply fetch a new thumbnail.
As we currently do not check eTags for thumbnails, I will create this in a different branch, so that this one will not blown up.

[tobiasKaminsky]

As comment PR is based on this, I did not rebase, but merge.
As soon as this is then ready, prior merging this PR we need to rebase, to get rid of the merge commit.

[tobiasKaminsky]

This is now ready for code review & testing.

[AndyScherzinger]

--> FileDetailActivitiesFragment ;)

[tobiasKaminsky]

Copy&paste error ;-)

[AndyScherzinger]

@tobiasKaminsky I only get an error screen (with the icon and so on) when opening a file that has versions on your testing Nc14 server instance :/

[tobiasKaminsky]

@AndyScherzinger can you write me on irc or per mail the exact file alongside with the credentials? Then I can have a look at exact the same file.

[tobiasKaminsky]

@AndyScherzinger this was because I cloned server manually and forgot activity app.
Please re-test it.

! I rebased it!

[AndyScherzinger]

@tobiasKaminsky shouldn't you have merged nextcloud/android-library#150 first and moved back to referencing master-SNAPSHOT???

[tobiasKaminsky]

Ups.
As I did not wrote this in the first comment, I just forgot about it :/

@mario can you quickly have a look at nextcloud/android-library#150? :-D

[AndyScherzinger]

@tobiasKaminsky nextcloud/android-library#150 has been merged and master has been build via jitpack