Iteration 5 for File detail & new sharing - Comments #2690

tobiasKaminsky · 2018-06-06T06:27:50Z

Based on #2685

TODO

make submit button nicer c2c338a
tint underline color d302e3f
Add support for file versions #2685 merged + rebased on master afterwards

enter a new comment
- refreshes activity stream
- or shows snackbar with error

AndyScherzinger · 2018-06-06T06:31:32Z

I'll take care of the button 👍

tobiasKaminsky · 2018-06-06T06:32:16Z

src/main/java/com/owncloud/android/ui/fragment/FileFragment.java


        Bundle bundle = getArguments();
-        setFile((OCFile) bundle.getParcelable(EXTRA_FILE));
+        setFile(bundle.getParcelable(EXTRA_FILE));


I accidentally touched the file and now AndroidStudio always tries to enhance this…

AndyScherzinger · 2018-06-06T09:23:35Z

@tobiasKaminsky button has been beautified, see c2c338a

AndyScherzinger · 2018-06-06T09:31:22Z

Edit Text tinting has been added via d302e3f

AndyScherzinger · 2018-06-06T15:27:54Z

@tobiasKaminsky except for the rebase/conflict-resolving is there anything left open for this PR since I did the 2 remaining TODOs you wrote down?

tobiasKaminsky · 2018-06-07T05:51:47Z

Same as the other PR, once this is ready an versions PR is merged, we need do rebase this.

tobiasKaminsky · 2018-06-07T05:52:24Z

This is now ready for review 👍

AndyScherzinger · 2018-06-07T10:50:40Z

👍 tested and works fine for me 👍

tobiasKaminsky · 2018-06-07T12:25:09Z

Thanks for testing 👍
Regarding the upcoming merge, I suggest, that we merge #2685, and then I rebase this against master and then we merge this like any other regular PR.

mario · 2018-06-10T20:03:00Z

Conflicts + submit button should be rotated by 45 degrees to the left.

AndyScherzinger · 2018-06-10T20:05:49Z

submit button should be rotated by 45 degrees to the left.

isn't Talk the only app doing this? 😝 (looking at mail/messengers/etc.)

mario · 2018-06-10T20:08:57Z

@AndyScherzinger yes. Consistency :P

mario · 2018-06-10T20:10:05Z

src/main/java/com/owncloud/android/operations/CommentFileOperation.java

+    private boolean isSuccess(int status) {
+        return status == HttpStatus.SC_CREATED;
+    }
+}


mario · 2018-06-10T20:10:16Z

src/main/java/com/owncloud/android/operations/CommentFileOperation.java

@@ -0,0 +1,112 @@
+/*


Whole file should be in a library.

General issue: ATM all "operations" are afaik not in the lib but the app...

General issue maybe, but at least move this NEW issue to the library.

Currently this cannot be moved this easily as these *Operation extends RemoteOperation which is a class in files app.

I guess you confuse it with *RemoteOperations, e.g.:

RemoveFileOperation is in Files app (handles app specific stuff)
RemoveRemoteFileOperation is in library (and handles the real webdav call)

tobiasKaminsky · 2018-06-14T12:31:21Z

submit button should be rotated by 45 degrees to the left.

isn't Talk the only app doing this? 😝 (looking at mail/messengers/etc.)

Having a look at material icons (https://material.io/tools/icons/?icon=send&style=baseline)

and our web ui:

We should rather change the icon in talk, to stay consistent.
@nextcloud/designers

tobiasKaminsky · 2018-06-14T12:38:32Z

! Rebased

jancborchardt · 2018-06-14T15:03:45Z

@tobiasKaminsky yup – the icon you show is correct. Looking at Signal they do the same.

The first line of the comment »Commented by you« is not really useful. It should simply say »You« instead
Similar for the icon: Instead of the generic comment icon, it should show your avatar
And the comment text below should have the same text size as the normal text. We shouldn’t have too many different text sizes as that looks strange.
We can remove the »Today« header – it’s not necessary to show that one. Should only start with »Yesterday«.

Also cc @nickvergessen cause I guess these things have to do with notifications?

AndyScherzinger · 2018-06-14T17:43:45Z

The first line of the comment »Commented by you« is not really useful. It should simply say »You« instead

That is the content we get from the server, so @nickvergessen or somebody else would have to change that in the server.

mario · 2018-06-14T20:48:09Z

👍

tobiasKaminsky · 2018-06-15T05:33:19Z

@jancborchardt this is all from server side, except of the date header "today, yesterday, …", which is the same as the activity stream.

Please do not merge this, as this would then be merged in versions branch.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

…inding

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

codecov · 2018-06-20T10:43:53Z

Codecov Report

Merging #2690 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2690      +/-   ##
=========================================
- Coverage    6.49%   6.48%   -0.01%     
=========================================
  Files         287     288       +1     
  Lines       29058   29108      +50     
  Branches     4234    4235       +1     
=========================================
+ Hits         1888    1889       +1     
- Misses      26886   26935      +49     
  Partials      284     284

Impacted Files	Coverage Δ
...cloud/android/operations/CommentFileOperation.java	`0% <0%> (ø)`
...roid/ui/fragment/FileDetailActivitiesFragment.java	`0% <0%> (ø)`	⬆️
...com/owncloud/android/ui/fragment/FileFragment.java	`0% <0%> (ø)`	⬆️
.../third_parties/daveKoeller/AlphanumComparator.java	`82.75% <0%> (+1.14%)`	⬆️

AndyScherzinger · 2018-06-20T11:03:45Z

Please do not merge this, as this would then be merged in versions branch.

@tobiasKaminsky you rebased the branch and versions has been merged, so I'd say the PR can be merged now, right? :)

jancborchardt · 2018-06-20T11:20:14Z

@tobiasKaminsky ok, will open in Activity then.

But text size is from Android also, right? Can you adjust that as I mentioned above?

tobiasKaminsky · 2018-06-20T11:50:09Z

@jancborchardt I will do it in a following PR / discuss in a new issue.

tobiasKaminsky added the 2. developing label Jun 6, 2018

tobiasKaminsky changed the base branch from master to versions June 6, 2018 06:28

tobiasKaminsky force-pushed the comments branch from faf9849 to fc0efdd Compare June 6, 2018 06:31

tobiasKaminsky commented Jun 6, 2018

View reviewed changes

tobiasKaminsky mentioned this pull request Jun 6, 2018

Roadmap: file detail & new sharing #2485

Closed

10 tasks

AndyScherzinger changed the title ~~Comments~~ Iteration 4 for File detail & new sharing - Comments Jun 6, 2018

tobiasKaminsky force-pushed the comments branch from e341568 to d302e3f Compare June 7, 2018 05:43

tobiasKaminsky added 3. to review and removed 2. developing labels Jun 7, 2018

mario reviewed Jun 10, 2018

View reviewed changes

AndyScherzinger changed the title ~~Iteration 4 for File detail & new sharing - Comments~~ Iteration 5 for File detail & new sharing - Comments Jun 12, 2018

tobiasKaminsky force-pushed the versions branch from 4dd1cac to 9fdb91e Compare June 14, 2018 05:06

tobiasKaminsky force-pushed the comments branch from 0dd1ddc to ef830be Compare June 14, 2018 12:38

nextcloud deleted a comment Jun 14, 2018

AndyScherzinger force-pushed the comments branch from fb4711e to b4c631b Compare June 14, 2018 21:43

AndyScherzinger force-pushed the versions branch from a56d234 to 818ec64 Compare June 14, 2018 21:44

AndyScherzinger force-pushed the comments branch from b4c631b to 88009bc Compare June 14, 2018 21:49

tobiasKaminsky force-pushed the comments branch from 88009bc to d69b51e Compare June 15, 2018 09:57

tobiasKaminsky changed the base branch from versions to master June 15, 2018 09:58

tobiasKaminsky and others added 7 commits June 20, 2018 11:14

Add file version to activity stream

22d53a2

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

butterknife for details fragment + proper empty content handling

c32986c

add avatar icons on sharee list

1ef3d29

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Add comments

5e50b6c

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

replace button with borderless image button + ripple effect + click b…

41528ab

…inding

tint edit text according to theming

695ed0f

changes due to rebase

b7ac2ee

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky force-pushed the comments branch from d69b51e to b7ac2ee Compare June 20, 2018 09:15

jancborchardt mentioned this pull request Jun 20, 2018

Improvements for Comments in Activity nextcloud/activity#278

Closed

tobiasKaminsky merged commit dc315a9 into master Jun 20, 2018

tobiasKaminsky deleted the comments branch June 20, 2018 11:49

tobiasKaminsky mentioned this pull request Jun 20, 2018

Activity stream design enhancements on file detail #2737

Closed

AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jun 20, 2018

AndyScherzinger mentioned this pull request Aug 22, 2018

Idea for enhancement: add possibility to insert a comment #1798

Closed

AndyScherzinger removed the 3. to review label Aug 29, 2018

Uh oh!

Iteration 5 for File detail & new sharing - Comments #2690

Iteration 5 for File detail & new sharing - Comments #2690

Uh oh!

Conversation

tobiasKaminsky commented Jun 6, 2018 • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger commented Jun 6, 2018

Uh oh!

tobiasKaminsky Jun 6, 2018

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger commented Jun 6, 2018

Uh oh!

AndyScherzinger commented Jun 6, 2018

Uh oh!

AndyScherzinger commented Jun 6, 2018

Uh oh!

tobiasKaminsky commented Jun 7, 2018

Uh oh!

tobiasKaminsky commented Jun 7, 2018

Uh oh!

AndyScherzinger commented Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasKaminsky commented Jun 7, 2018

Uh oh!

mario commented Jun 10, 2018

Uh oh!

AndyScherzinger commented Jun 10, 2018

Uh oh!

mario commented Jun 10, 2018

Uh oh!

mario Jun 10, 2018

Choose a reason for hiding this comment

Uh oh!

mario Jun 10, 2018

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger Jun 10, 2018

Choose a reason for hiding this comment

Uh oh!

mario Jun 10, 2018

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky commented Jun 14, 2018

Uh oh!

tobiasKaminsky commented Jun 14, 2018

Uh oh!

jancborchardt commented Jun 14, 2018

Uh oh!

AndyScherzinger commented Jun 14, 2018

Uh oh!

mario commented Jun 14, 2018 • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasKaminsky commented Jun 15, 2018

Uh oh!

codecov bot commented Jun 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AndyScherzinger commented Jun 20, 2018

Uh oh!

jancborchardt commented Jun 20, 2018

Uh oh!

tobiasKaminsky commented Jun 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

tobiasKaminsky commented Jun 6, 2018 •

edited by AndyScherzinger

Loading

AndyScherzinger commented Jun 7, 2018 •

edited

Loading

mario commented Jun 14, 2018 •

edited by AndyScherzinger

Loading

codecov bot commented Jun 20, 2018 •

edited

Loading

tobiasKaminsky commented Jun 20, 2018 •

edited

Loading