after download: update file via remote id

[tobiasKaminsky]

Found via google play console:

Caused by: java.lang.NullPointerException: 
  at com.owncloud.android.ui.activity.FileDisplayActivity$DownloadFinishReceiver.onReceive (FileDisplayActivity.java:1493)
  at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$-android_app_LoadedApk$ReceiverDispatcher$Args_52225 (LoadedApk.java:1319)

android/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java

Lines 1518 to 1520 in f880111

	if (mWaitingToSend != null) {
	mWaitingToSend = getStorageManager().getFileByPath(mWaitingToSend.getRemotePath());
	if (mWaitingToSend.isDown() && downloadBehaviour != null) {

The file gets refreshed because metadata could have changed.
Somehow then storageManager cannot find it anylonger.
(mWaitingToSend is not null, as this would produce an IllegalArgumentException).
So my assumption is that somehow the the remote path is changed and thus the file cannot be found anymore.
--> remoteId stays the same, so it is better to use.

Additionally, I added a null check, so that in doubt nothing happens, but at least also do not crash.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

Lint

96 warnings

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	158
Security Warnings	163
Dodgy code Warnings	209
Total	765

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	158
Security Warnings	163
Dodgy code Warnings	209
Total	765

[codecov]

Codecov Report

Merging #2776 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2776      +/-   ##
=========================================
+ Coverage    6.37%   6.38%   +<.01%     
=========================================
  Files         294     294              
  Lines       29563   29569       +6     
  Branches     4268    4269       +1     
=========================================
+ Hits         1885    1888       +3     
- Misses      27389   27394       +5     
+ Partials      289     287       -2

Impacted Files	Coverage Δ
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	⬆️
...loud/android/datamodel/FileDataStorageManager.java	10.52% <0%> (-0.06%)	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	63.32% <0%> (+1.15%)	⬆️

[AndyScherzinger]

👍

[mario]

👍