Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

  • move all operation to library
  • rename library operation to RemoteOperation
  • some cleanups

rename library operation to RemoteOperation
some cleanups

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

Ready to review

AndyScherzinger and others added 2 commits December 10, 2018 09:48
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

@AndyScherzinger I fixed a failing test, hopefully it now turns green.

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings8585
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings161
Internationalization Warnings15
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings204
Dodgy code Warnings135
Total689

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings162
Internationalization Warnings15
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings204
Dodgy code Warnings135
Total690

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Dec 10, 2018

👍 feel free to merge :)

Approved with PullApprove

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #3324 into master will decrease coverage by 0.01%.
The diff coverage is 9.8%.

@@             Coverage Diff             @@
##             master   #3324      +/-   ##
===========================================
- Coverage      6.16%   6.15%   -0.02%     
  Complexity        1       1              
===========================================
  Files           317     315       -2     
  Lines         30516   30440      -76     
  Branches       4389    4388       -1     
===========================================
- Hits           1882    1874       -8     
+ Misses        28349   28279      -70     
- Partials        285     287       +2
Impacted Files Coverage Δ Complexity Δ
...om/owncloud/android/utils/FileSortOrderByDate.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <ø> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderBySize.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../java/com/owncloud/android/utils/MimeTypeUtil.java 79.17% <ø> (ø) 0 <0> (ø) ⬇️
...java/com/owncloud/android/utils/FileSortOrder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java 12.59% <ø> (ø) 0 <0> (ø) ⬇️
...loud/android/ui/activities/ActivitiesActivity.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderByName.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...wncloud/android/ui/trashbin/TrashbinPresenter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...owncloud/android/ui/trashbin/TrashbinActivity.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 33 more

1 similar comment
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #3324 into master will decrease coverage by 0.01%.
The diff coverage is 9.8%.

@@             Coverage Diff             @@
##             master   #3324      +/-   ##
===========================================
- Coverage      6.16%   6.15%   -0.02%     
  Complexity        1       1              
===========================================
  Files           317     315       -2     
  Lines         30516   30440      -76     
  Branches       4389    4388       -1     
===========================================
- Hits           1882    1874       -8     
+ Misses        28349   28279      -70     
- Partials        285     287       +2
Impacted Files Coverage Δ Complexity Δ
...om/owncloud/android/utils/FileSortOrderByDate.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <ø> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderBySize.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../java/com/owncloud/android/utils/MimeTypeUtil.java 79.17% <ø> (ø) 0 <0> (ø) ⬇️
...java/com/owncloud/android/utils/FileSortOrder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java 12.59% <ø> (ø) 0 <0> (ø) ⬇️
...loud/android/ui/activities/ActivitiesActivity.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderByName.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...wncloud/android/ui/trashbin/TrashbinPresenter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...owncloud/android/ui/trashbin/TrashbinActivity.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 33 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants