-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Move operations to library #3324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobiasKaminsky
commented
Dec 7, 2018
- move all operation to library
- rename library operation to RemoteOperation
- some cleanups
rename library operation to RemoteOperation some cleanups Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
fc508f1 to
43ce903
Compare
Member
Author
|
Ready to review |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Member
Author
|
@AndyScherzinger I fixed a failing test, hopefully it now turns green. |
Collaborator
Lint
FindBugs (new)
FindBugs (master)
|
Merged
Member
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
===========================================
- Coverage 6.16% 6.15% -0.02%
Complexity 1 1
===========================================
Files 317 315 -2
Lines 30516 30440 -76
Branches 4389 4388 -1
===========================================
- Hits 1882 1874 -8
+ Misses 28349 28279 -70
- Partials 285 287 +2
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
===========================================
- Coverage 6.16% 6.15% -0.02%
Complexity 1 1
===========================================
Files 317 315 -2
Lines 30516 30440 -76
Branches 4389 4388 -1
===========================================
- Hits 1882 1874 -8
+ Misses 28349 28279 -70
- Partials 285 287 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.