Switch to AndroidX

[tobiasKaminsky]

This was done automatically by AndroidStudio and "should" only be a replace of imports and names.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

Well... drone raises 83 compile errors so at least the build fails in CI

[tobiasKaminsky]

Seems to come from butterknife, so we have to wait a bit for a new release there.

I tried to use latest master branch via jitpack, but this fails due to annotationProcessor.

[tobiasKaminsky]

With Butterknife 9.0.0 SNAPSHOT it is compiling, but we should wait for a stable release!

[AndyScherzinger]

Butterknife reached RC1 status, so we are getting there :) https://github.com/JakeWharton/butterknife/releases/tag/9.0.0-rc1

[AndyScherzinger]

https://github.com/JakeWharton/butterknife/releases/tag/9.0.0-rc2 has been released, so we are getting there, slow and steady :P

[tobiasKaminsky]

@AndyScherzinger I would go with RC2.
After all we have it only in master and thus in dev version.
Upcoming 3.4.0 is already branched and 3.5.0 is in ~3 months.

I'll update this one.

[tobiasKaminsky]

Removed pending codacy warnings and rebased.

[AndyScherzinger]

@tobiasKaminsky sure fine with me. Do you have the time to fix the 2 lint errors? Then I'd say we are fine with merging it afterwards :)

[tobiasKaminsky]

i fixed them, but we have to rebase once #3324 is merged.

[tobiasKaminsky]

Rebased again after #3324 was merged.
@AndyScherzinger you can merge it then 👍

[AndyScherzinger]

👍 just waiting for droneCI

[tobiasKaminsky]

/drone/src/github.com/nextcloud/android/build/intermediates/tmp/manifest/androidTest/gplay/debug/manifestMerger6179616085388600567.xml:30:5-33:72 Error:
uses-sdk:minSdkVersion 14 cannot be smaller than version 18 declared in library [androidx.test.uiautomator:uiautomator:2.2.0] /root/.gradle/caches/transforms-1/files-1.1/uiautomator-2.2.0.aar/944e6445ad4568ed241e4c9f8c938d6e/AndroidManifest.xml as the library might be using APIs not available in 14
Suggestion: use a compatible library with a minSdk of at most 14,
or increase this project's minSdk version to at least 18,
or use tools:overrideLibrary="android_libs.ub_uiautomator" to force usage (may lead to runtime failures)

I will have a look.

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	85	84
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	204
Dodgy code Warnings	135
Total	687

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	161
Internationalization Warnings	15
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	204
Dodgy code Warnings	135
Total	689

[tobiasKaminsky]

@AndyScherzinger currently we do not use UI automator, so I disabled it for now :hide: