Skip to content

Fix crash when drawing play icon on video thumbnail #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezaquarii wants to merge 1 commit into from
Closed

Fix crash when drawing play icon on video thumbnail #4155

ezaquarii wants to merge 1 commit into from

Conversation

@ezaquarii
Copy link
Collaborator

@ezaquarii ezaquarii commented Jun 16, 2019 •
edited
Loading

Bitmap decoder does not work with vector drawables.

Fixes #4129
Fixes #4150

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

@ezaquarii
Fix crash when drawing play icon on video thumbnail
f76b707 
Bitmap decoder does not work with vector drawables.

Fixes #4129
Fixes #4150

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@ezaquarii ezaquarii force-pushed the ezaquarii/fix-crash-when-displaying-video-thumbnail branch from e661574 to f76b707 Compare June 16, 2019 14:02
@ezaquarii
Copy link
Collaborator Author

ezaquarii commented Jun 16, 2019

@AndyScherzinger @tobiasKaminsky This should go into 3.7.0

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jun 16, 2019

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9755.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jun 16, 2019

Codacy

306

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

This was referenced Jun 16, 2019
Closed
Closed
@ezaquarii
Copy link
Collaborator Author

ezaquarii commented Jun 16, 2019

Comprehensive fix in #4156

@ezaquarii ezaquarii closed this Jun 16, 2019
@ezaquarii ezaquarii deleted the ezaquarii/fix-crash-when-displaying-video-thumbnail branch June 16, 2019 15:06
@doits
Copy link

doits commented Jun 17, 2019

👍 fixes my issue #4150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App crash on startup (something with thumbnails) App crashes upon start.

4 participants

@ezaquarii @nextcloud-android-bot @doits